Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS support for canonical names #2375

Closed
wants to merge 12 commits into from
Closed

Conversation

ilanolkies
Copy link
Contributor

This EIP specifies a resolver for canonical name resolution for ENS. This permits identifying the same resource with several names.

@axic axic added the type: ERC label Nov 22, 2019
Copy link
Contributor

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace the delegate call with a static call.

EIPS/eip-2375.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 8, 2020

There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Sep 8, 2020
EIPS/eip-2375.md Outdated Show resolved Hide resolved
EIPS/eip-2375.md Show resolved Hide resolved
@MicahZoltu
Copy link
Contributor

@ilanolkies This draft is pretty old, and I apologize on behalf of the editors to not merging it sooner. Given its age, I wanted to check with you to make sure you are still interested in pursuing this before merging. If not we can just close this PR, but if you are interested we can merge it (I encourage you to make the suggested changes first though).

@github-actions github-actions bot removed the stale label Sep 9, 2020
@ilanolkies
Copy link
Contributor Author

Hi. I can work on it during this month to have a new revision ready. Thanks

@ilanolkies
Copy link
Contributor Author

Also ens-cname repo updated and added test case for addr resolution.

Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this, I want to make sure this is appropriate as an EIP. Keep in mind, not all Good Ideas are good candidates for being standardized. Why does an ENS feature need an EIP? Can't you just add the feature to ENS without creating a standard? There is only one ENS, which suggests that you could just publish some updated ENS documentation without an EIP.

}
```

## Copyright
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Copyright
## Security Considerations
TBD
## Copyright

Copy link
Contributor Author

@ilanolkies ilanolkies Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Copyright
## Security considerations
- Aliases pointing to other aliases produce inefficient gas usage.
- Aliases loops produce gas limit exceeded. The domain will no longer be resolved.
## Copyright

Comment on lines +28 to +40
A resolver supporting `cname` interface identifies its name as an alias, and specifies the corresponding canonical name. It must provide a fallback function that:

1. Fetches the canonical name of the queried name.
4. Replaces the canonical name in the call data.
2. Fetches the canonical name's resolver.
3. Queries the canonical name's resolver.<sup>1</sup>

If a `cname` resolution is present at a node, no other resolution should be present; this ensures that the data for a canonical name and its aliases cannot be different.

Domain names which point at another name should always point at the primary name and not the alias. This avoids extra indirections in
accessing information.

By the robustness principle, domain resolution should not fail when presented with `cname` chains or loops; `cname` chains should be followed and `cname` loops signalled as an error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but this doesn't look nearly specific enough to be a standard. It seems to just describe an idea in high level terms. It describes a fallback function that does some stuff and doesn't return anything, which suggests that the "stuff" it does is just an implementation detail and not relevant to the spec, at which point this spec is pretty meaningless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial idea was specifying a cname standard record that was queried after a 0 response from a resolver. Then, it evolved into a resolver implementing this “substitution”. The discussion was held in ENS forum and was lost.

eip: 2375
title: ENS support for canonical names
author: Ilan Olkies (@ilanolkies)
discussions-to: https://discuss.ens.domains/t/new-standard-proposal-ens-cname-support/1236
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead link. Needs to be fixed for merge.

@github-actions
Copy link

There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Nov 30, 2020
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants