Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1193: Move to Last Call #2610

Merged
merged 2 commits into from
Apr 24, 2020
Merged

1193: Move to Last Call #2610

merged 2 commits into from
Apr 24, 2020

Conversation

rekmarks
Copy link
Contributor

@rekmarks rekmarks commented Apr 23, 2020

Moves EIP 1193 to Last Call, with the review period ending after 6 weeks on 2020-06-04 (June 4, 2020).

Review period format follows the convention of the majority of EIPs in Last Call, e.g. https://eips.ethereum.org/EIPS/eip-875

@eip-automerger
Copy link

eip-automerger commented Apr 23, 2020

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 1193 state from Draft to Last Call

Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ryanio
Copy link
Contributor

ryanio commented Apr 23, 2020

Looks like we need an EIP editor to approve changing the state to Last Call. Here is some of the recent discussion for context: #2319 (comment)

@rekmarks
Copy link
Contributor Author

Pinging @axic, as he's been involved pretty recently.

@axic axic merged commit 5cf7132 into ethereum:master Apr 24, 2020
@rekmarks rekmarks deleted the 1193-last-call branch April 24, 2020 14:18
pizzarob pushed a commit to pizzarob/EIPs that referenced this pull request Jun 12, 2020
* move to last call

* fixup! move to last call
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
* move to last call

* fixup! move to last call
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
* move to last call

* fixup! move to last call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants