EIP-695: clarify what happens if a chain initially does not have chain ID or chain ID has changed #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n ID or chain ID has changed
axic
reviewed
May 5, 2020
| @@ -36,6 +36,10 @@ the RPC. | |||
| Returns the currently configured chain ID, a value used in replay-protected transaction | |||
| signing as introduced by [EIP-155](./eip-155.md). | |||
There was a problem hiding this comment.
All these links should be pointing to `https://eips.ethereum.org/EIPS/eip-155, etc.
Merged
pizzarob
pushed a commit
to pizzarob/EIPs
that referenced
this pull request
Jun 12, 2020
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://ethereum-magicians.org/t/eip-695-create-eth-chainid-method-for-json-rpc/1845/19
We clarify that chain ID returned should always be corresponding to the head block. This is also how OpenEthereum currently implements it. The rationale is that by doing this we ensure caller can always use the retrieved information to sign transactions on top of the head.