EIP-2315: updated testcases + clarifications #2656
Conversation
|
|
||
|
|
||
| ``` | ||
| Error: at pc=0, op=BEGINSUB: invalid subroutine entry |
There was a problem hiding this comment.
Do we want an OOG message or another like invalid subroutine entry ?
If we want to use this new message maybe we need to update this part https://github.com/ethereum/EIPs/blob/master/EIPS/eip-2315.md#beginsub ?
|
The actual error message is not part of consensus
|
yes indeed it's just to have a consistency :) |
|
Well, I think saying "it goes OOG", means that it will "consensus-wise" behave as an OOG, which is a well-understood failure mode at this time. Whether the human-readable strings that a client spits out says that or something else is not something that should be defined in the EIP, imo. If we want more consistency, it would be more suited for another eip (not But I guess it's un-intuitive that the EIP says OOG error but the EIP-examples says something else. SO may be I should clarify in the EIP that the testcases/examples are based on geth and the message itself is an implementation detail. |
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
This PR contains the updated testcases with the recent changes. Also some clarifications and I re-added cost of
BEGINSUB. All opcodes should have a defined cost, IMO.