Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Network upgrade postmortem template.md #2810

Closed
wants to merge 3 commits into from
Closed

Create Network upgrade postmortem template.md #2810

wants to merge 3 commits into from

Conversation

poojaranjan
Copy link
Contributor

Network upgrade postmortem report template.

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Network upgrade postmortem report template.
@MicahZoltu
Copy link
Contributor

Same comments as over in #2809, I don't think the EIP repository is the right place for post mortems of Ethereum mainnet operations.

@poojaranjan
Copy link
Contributor Author

This PR is created to add a template to create the network upgrade postmortem report and be saved as an Informational EIP for community reference. 

Being a template, I've added Type = Meta (Ref. EIP 233, a template for creating the hardfork meta EIP). However, this is not a proposal related to the network standard, so, if suggested, "Type' can be changed to "Informational EIP" to get it merged. 

IMO, changing the type of proposal will let this template sit as a recommendation and not a mandate to be followed to create the network upgrade postmortem/assessment report. 

author: Pooja Ranjan
discussions-to:
status: Draft
type: Meta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be informational.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I take that back. I think this EIP should be meta, but it should specify that EIPs that follow this template are informational.

@github-actions
Copy link

github-actions bot commented Oct 2, 2020

There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Oct 2, 2020
@github-actions
Copy link

github-actions bot commented Oct 9, 2020

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants