Switch validator to eipv #2860

lightclient · 2020-08-06T20:39:56Z

As discussed in the EIPIP meetings, I've been working on a new validator called eipv. It isn't feature complete yet, but it should be comparable to the existing validator.

axic · 2020-08-06T22:57:12Z

EIPS/eip-196.md

@@ -1,7 +1,6 @@
 ---
 eip: 196
-title: Precompiled contracts for addition and scalar multiplication
-       on the elliptic curve alt_bn128
+title: Precompiled contracts for addition and scalar multiplication on the elliptic curve alt_bn128
 author: Christian Reitwiessner<[email protected]>


lightclient · 2020-08-06T23:12:34Z

@axic @MicahZoltu @gcolvin @Souptacular @nicksavers: thoughts on this PR?

lightclient · 2020-08-06T23:17:47Z

.travis-ci.sh

-
-  FILES="$(ls EIPS/*.md | egrep "eip-[0-9]+.md")"
-  bundle exec eip_validator $FILES
+  eipv EIPS/ --ignore=title_max_length,missing_discussions_to --skip=eip-20-token-standard.md


Please note that the validator is currently not ensuring that titles are less than the max specified length and that each EIP has a discussions-to field. This is due to the number of non-conforming EIPs. I think formally increasing the max title length to support all current EIPs and then turning on the check is acceptable. With regards to the discussions-to field, there are some options:

In a separate PR, go in and create discussions threads for every EIP missing one

Do 1) in this PR

Forget historic EIPs with no discussions-to and only check new ones

I prefer 1.

I prefer 1 or 2. Anything that gets the system into a more standardized state so we can reliably use the bot going forward and don't need to maintain code to support malformed ancient EIPs.

Also, prefer 1 or 2

I'll follow the 1 path.

eip-automerger · 2020-08-06T23:18:01Z

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

File .travis-ci.sh is not an EIP
File .travis.yml is not an EIP
EIP 1 is in state Active, not Draft or Last Call
EIP 1057 is in state Accepted, not Draft or Last Call
Error checking file EIPS/eip-1337.md
EIP 1355 is in state Abandoned, not Draft or Last Call
Error checking file EIPS/eip-1485.md
Error checking file EIPS/eip-1571.md
Error checking file EIPS/eip-1613.md
Error checking file EIPS/eip-1620.md
EIP 1679 is in state Final, not Draft or Last Call
EIP 1884 is in state Final, not Draft or Last Call
Error checking file EIPS/eip-1895.md
EIP 196 is in state Final, not Draft or Last Call
EIP 197 is in state Final, not Draft or Last Call
Error checking file EIPS/eip-2009.md
EIP 214 is in state Final, not Draft or Last Call
Error checking file EIPS/eip-2477.md
EIP 601 is in state Final, not Draft or Last Call
Error checking file EIPS/eip-615.md
Error checking file EIPS/eip-698.md
Error checking file EIPS/eip-712.md
Error checking file EIPS/eip-884.md
Error checking file EIPS/eip-998.md
EIP 1078 requires approval from one of ([email protected])
EIP 1153 requires approval from one of (@AlexeyAkhunov)
EIP 1186 requires approval from one of ([email protected], [email protected])
EIP 1191 requires approval from one of (@juli)
EIP 1271 requires approval from one of (@izqui, @PhABC, @abandeali1, @catageek, @shrugs, @frangio)
EIP 1470 requires approval from one of (@thec00n)
EIP 1973 requires approval from one of (@lerajk, @qinjian)
EIP 2193 requires approval from one of (@ctzurcanu, @loredanacirstea)
EIP 2378 requires approval from one of (@MadeofTin)
EIP 2458 requires approval from one of (@edsonayllon)
EIP 2470 requires approval from one of (@3esmit)
EIP 2525 requires approval from one of (@Amxx)
EIP 2657 requires approval from one of (@MadeofTin)
EIP 2746 requires approval from one of (@juanfranblanco, @jaerith)
EIP 2767 requires approval from one of (@mudgen, @zemse)
EIP 634 requires approval from one of (@ricmoo)

lightclient · 2020-08-06T23:18:11Z

EIPS/eip-1.md

@@ -4,7 +4,6 @@ title: EIP Purpose and Guidelines
 status: Active
 type: Meta
 author: Martin Becze <[email protected]>, Hudson Jameson <[email protected]>, and others
-        https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1.md


It's not clear what purpose this URL served here.

I have changed this file locally just never submitted a PR. My understanding it tries to signal "look at the history".

What I opted for was "Martin ..., Hudson ..., et al."

Oh I see, it was supposed to be a part of the authors field.

Can we change the authors for EIP-1 to just "Contributors Like You". 🚎 /not-🚎

I don't have a strong feeling towards this, but IMO it's outside the scope of this PR.

lightclient · 2020-08-06T23:19:15Z

EIPS/eip-1485.md

@@ -1,7 +1,7 @@
 ---
 eip: 1485
 title: TEthashV1
-author: trustfarm (KT Ahn - 안씨아저씨) <[email protected]>, trustfarm <[email protected]>
+author: trustfarm KT Ahn - 안씨아저씨 <[email protected]>, trustfarm <[email protected]>


I'm not sure if this is the best way to handle this. I'm not sure what the author was hoping to convey using the parentheses.

I would probably talk to the author but my gut says to just remove the stuff in parenthesis. It seems like that email address is a company owned address, and the person on the other end of that address is subject to change. EIP Authors should not be subject to change IMO, so I think just trustfarm is appropriate.

3esmit · 2020-08-06T23:58:17Z

I approve the change in ERC-2470 date format.

EIPS/eip-1078.md

MicahZoltu · 2020-08-07T08:54:29Z

EIPS/eip-1355.md

-author: Paweł Bylica (@chfast) <[email protected]>, Jean M. Cyr (@jean-m-cyr)
+author: Paweł Bylica (@chfast), Jean M. Cyr (@jean-m-cyr)


I wonder if we should include the person twice in this case, so that they are a valid author both by email and by GitHub handle?

(same comment elsewhere where this change was made)

MicahZoltu · 2020-08-07T08:56:38Z

Can you give us a snippet of what the errors look like? One of my biggest complaints about the validator is how cryptic some of its errors are. Would be nice to get the error messaging improved...

MicahZoltu

If it is as functional as the previous one, and has someone to support it (you) then I say we move forward with it and see how things go. If they go poorly, we can always rollback.

I don't have any strong negative feelings towards any of the EIP updates you have made here, though I did leave some comments.

MadeofTin · 2020-08-07T14:00:13Z

cc @Souptacular to merge. :)

lightclient · 2020-08-07T14:18:05Z

Can you give us a snippet of what the errors look like? One of my biggest complaints about the validator is how cryptic some of its errors are. Would be nice to get the error messaging improved...

Here is what CI was spitting out at the beginning of the PR: https://travis-ci.org/github/ethereum/EIPs/jobs/715639437#L643-L686. The main goal was to minimize the number of runtime errors that the old validator was providing, which (by writing in Rust) I believe this validator has accomplished. The general form of errors is eip-N: error text. I plan to improve this in the near future to also point to the line where the error was encountered.

For a full list of supported errors, please see: https://github.com/lightclient/eipv/blob/0e84318896dfec2024206f8bab8a9625ba8a75e4/src/error.rs#L56-L102

lightclient · 2020-08-10T15:07:24Z

Bumping, @axic, @Souptacular, @gcolvin -- any thoughts? Is this okay to merge? The longer we wait, the more conflicts that will pile up here.

Souptacular · 2020-08-10T16:19:00Z

Merged! Thank you for the hard work @lightclient.

lightclient · 2020-08-10T16:21:26Z

Woohoo! Thank you @Souptacular.

* switch to eipv * fix * fix * 1153 remove trailing whitespace * remove file name checks * 615 remo whitespace before comma * 884 remove extra single-quotes * 1337 remove whitespace before comma * 1057 remove extra spaces after comma * 2470 update created date to Y/M/D format * 1078 update required eips to be in ascending order * 2477 update required eips to be in ascending order * 1271 remove extra whitespace * 2767 required eipupdated to be in ascending order * 2525 update created date to Y/M/D format * 2458 remove trailing whitespace * 1884 remove trailing whitespace * 712 authors should be on a single line * 601 remove extra whitespace * 1485 remove unneeded parentheses * 634 remove trailing whitespace * 2657 update discussions-to to correct spelling * 2009 remove trailing whitespace * 998 required eips updated to be in ascending order * 1186 remove trailing whitespace * 1470 remove extra whitespace * 1895 update created date to Y/M/D format * 2747 remove extra whitespace * 1613 remove leading whitespace * 1571 can'have both handle and email in author field * 1191 remove trailing whitespace * 1973 remove trailing whitespace * 196 don't wrap title field * 1679 required eips must be in ascending order * 1620 author can't have both handle and email * 197 don't line wrap title field * 2378 remove extra newline * 1355 author can't have both handle and email * 698 update created date to Y/M/D format * 2193 required eips must be in ascending order * 214 remove extra info after author email * use v0.0.3 of eipv * 1 remove malformed field * bump eipv to v0.0.4 * cache eipv build * 1485 remove extra author info * 2771 removing extra whitespaces

axic reviewed Aug 6, 2020

View reviewed changes

lightclient marked this pull request as ready for review August 6, 2020 23:11

lightclient commented Aug 6, 2020

View reviewed changes

MicahZoltu reviewed Aug 7, 2020

View reviewed changes

EIPS/eip-1078.md Show resolved Hide resolved

MicahZoltu reviewed Aug 7, 2020

View reviewed changes

MicahZoltu approved these changes Aug 7, 2020

View reviewed changes

lightclient force-pushed the update-eip-validator branch from f2e966b to c29ed4d Compare August 7, 2020 14:17

lightclient force-pushed the update-eip-validator branch from c29ed4d to 04d7976 Compare August 7, 2020 14:21

chfast approved these changes Aug 7, 2020

View reviewed changes

drortirosh approved these changes Aug 7, 2020

View reviewed changes

lightclient force-pushed the update-eip-validator branch from 04d7976 to 45c06d4 Compare August 10, 2020 15:10

lightclient added 10 commits August 10, 2020 09:10

switch to eipv

bff86e3

fix

533bb1a

fix

0cbcc94

1153 remove trailing whitespace

f6aeded

remove file name checks

e25dd51

615 remo whitespace before comma

838d6a7

884 remove extra single-quotes

531fc72

1337 remove whitespace before comma

a04f6ae

1057 remove extra spaces after comma

315ae8a

2470 update created date to Y/M/D format

e716f61

lightclient added 22 commits August 10, 2020 09:10

1470 remove extra whitespace

a41e4ae

1895 update created date to Y/M/D format

db83eec

2747 remove extra whitespace

57c9e28

1613 remove leading whitespace

c3da24f

1571 can'have both handle and email in author field

64bc976

1191 remove trailing whitespace

d038a25

1973 remove trailing whitespace

75986bd

196 don't wrap title field

39d6036

1679 required eips must be in ascending order

4c7851a

1620 author can't have both handle and email

0fa9d62

197 don't line wrap title field

3d2a8ac

2378 remove extra newline

f48a465

1355 author can't have both handle and email

81e7d61

698 update created date to Y/M/D format

7a25c9b

2193 required eips must be in ascending order

128404e

214 remove extra info after author email

d274a9f

use v0.0.3 of eipv

2da2916

1 remove malformed field

87f75fc

bump eipv to v0.0.4

89af85b

cache eipv build

35da03e

1485 remove extra author info

bb0d5b5

2771 removing extra whitespaces

45c06d4

Souptacular merged commit 3194278 into ethereum:master Aug 10, 2020

This was referenced Aug 11, 2020

EIPIP Meeting 14 Agenda ethcatherders/EIPIP#26

Closed

Fix eip-1679 rendering #2873

Merged

axic mentioned this pull request Sep 9, 2020

Introduce more automation #2961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch validator to eipv #2860

Switch validator to eipv #2860

lightclient commented Aug 6, 2020

axic Aug 6, 2020

lightclient commented Aug 6, 2020 •

edited

Loading

lightclient Aug 6, 2020

MicahZoltu Aug 7, 2020

MadeofTin Aug 7, 2020

lightclient Aug 7, 2020

eip-automerger commented Aug 6, 2020 •

edited

Loading

lightclient Aug 6, 2020

axic Aug 6, 2020

lightclient Aug 6, 2020

MicahZoltu Aug 7, 2020 •

edited

Loading

lightclient Aug 7, 2020

lightclient Aug 6, 2020

MicahZoltu Aug 7, 2020 •

edited

Loading

lightclient Aug 7, 2020

3esmit commented Aug 6, 2020 •

edited

Loading

MicahZoltu Aug 7, 2020

MicahZoltu Aug 7, 2020

MicahZoltu commented Aug 7, 2020

MicahZoltu left a comment

MadeofTin commented Aug 7, 2020

lightclient commented Aug 7, 2020

lightclient commented Aug 10, 2020

Souptacular commented Aug 10, 2020

lightclient commented Aug 10, 2020

		author: Paweł Bylica (@chfast) <[email protected]>, Jean M. Cyr (@jean-m-cyr)
		author: Paweł Bylica (@chfast), Jean M. Cyr (@jean-m-cyr)

Switch validator to eipv #2860

Switch validator to eipv #2860

Conversation

lightclient commented Aug 6, 2020

Choose a reason for hiding this comment

lightclient commented Aug 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eip-automerger commented Aug 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MicahZoltu Aug 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MicahZoltu Aug 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

3esmit commented Aug 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MicahZoltu commented Aug 7, 2020

MicahZoltu left a comment

Choose a reason for hiding this comment

MadeofTin commented Aug 7, 2020

lightclient commented Aug 7, 2020

lightclient commented Aug 10, 2020

Souptacular commented Aug 10, 2020

lightclient commented Aug 10, 2020

lightclient commented Aug 6, 2020 •

edited

Loading

eip-automerger commented Aug 6, 2020 •

edited

Loading

MicahZoltu Aug 7, 2020 •

edited

Loading

MicahZoltu Aug 7, 2020 •

edited

Loading

3esmit commented Aug 6, 2020 •

edited

Loading