Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1202 stagnant ([email protected]) #4193

Closed
wants to merge 1 commit into from

Conversation

eth-bot
Copy link
Collaborator

@eth-bot eth-bot commented Sep 20, 2021

This EIP has not been active since ([email protected]); which, is greater than the allowed time of 6 months.

authors: @xinbenlv, @evbots, @yingogobot

@eth-bot eth-bot marked this pull request as ready for review September 20, 2021 04:08
@xinbenlv
Copy link
Contributor

@eth-bot please close per #3848

@alita-moore
Copy link
Contributor

@xinbenlv can you leave a request changes review? the bot can't interpret it otherwise

@xinbenlv
Copy link
Contributor

@alita-moore, already did in #4190

@alita-moore
Copy link
Contributor

also @MicahZoltu do we want a feature to also consider PRs open against the file?

@alita-moore
Copy link
Contributor

@xinbenlv what I'm saying is can you please leave a negative review on this PR; it can be used later for determining if it should open a PR

@xinbenlv
Copy link
Contributor

xinbenlv commented Sep 20, 2021

love to comply, how do i do that(what do you mean "when you say leave a negative review"?) can you give example?

Copy link
Contributor

@alita-moore alita-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MicahZoltu
Copy link
Contributor

also @MicahZoltu do we want a feature to also consider PRs open against the file?

Yes, we should only open these if there are no pending PRs against the EIP.

@MicahZoltu
Copy link
Contributor

We shouldn't be leaving these open once an author has created a PR to update. Otherwise we just end up with a double-PRs against such EIPs which can be confusing.

@MicahZoltu MicahZoltu closed this Sep 20, 2021
@alita-moore
Copy link
Contributor

We shouldn't be leaving these open once an author has created a PR to update. Otherwise we just end up with a double-PRs against such EIPs which can be confusing.

Okay, do you mind adding this as a feature request in the eip-bot repo?

@axic axic deleted the mark-eip-1202-stagnant-([email protected]) branch September 20, 2021 17:29
@MicahZoltu
Copy link
Contributor

@xinbenlv You may see the bot open another of these next week, which we apologize for. Just link to your open PR and we'll close the PR just like here. ethereum/EIP-Bot#17 will fix this, but it may not be implemented before the next round of bot actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants