Non-Fungible Token with usage rights #4512

KKimos · 2021-12-01T02:40:46Z

This standard adds a new right of Non-Fungible Token that the right to use. Through this standard, you can achieve :

Separation of the right to use and ownership of Non-Fungible Token
Non-secured lease Non-Fungible Token
You can continue to use it after you mortgage the Non-Fungible Token
Metaverse sharing economy
It is precisely because of the separation of ownership and use right that the utilization rate of assets can be greater. You must distinguish between the rights of the user and the owner.

Different from 2615, we only added a right to use, so that we can get all the functions of 2615, and reduce many unnecessary operations in 2615. The explanation is as follows:

The owner should not use some of the ownership rights when mortgage NFT, such as transfer, AXS-like breeding or weapon upgrade, because it is likely to change the status of the original NFT, so when the user mortgages the NFT, the ownership must be mortgaged in the contract middle.
In the case of mortgage or transaction, the owner has the right to continue to use it before returning the ransom or selling it
This is the result of my implementation, you can refer to https://github.com/KKimos/ERCX

eth-bot · 2021-12-01T02:41:25Z

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) eip-4512.md

File with name EIPS/eip-4512.md is new and new files must be reviewed
This PR requires review from one of [@lightclient, @axic]

(pass) assets/eip-4512/LICENSE

file assets/eip-4512/LICENSE is associated with EIP 4512; because there are also changes being made to EIPS/eip-4512.md all changes to corresponding assets are also allowed

(pass) assets/eip-4512/README.md

file assets/eip-4512/README.md is associated with EIP 4512; because there are also changes being made to EIPS/eip-4512.md all changes to corresponding assets are also allowed

(pass) assets/eip-4512/contracts/ERCX.sol

file assets/eip-4512/contracts/ERCX.sol is associated with EIP 4512; because there are also changes being made to EIPS/eip-4512.md all changes to corresponding assets are also allowed

(pass) assets/eip-4512/contracts/extensions/ERCXEnumerable.sol

file assets/eip-4512/contracts/extensions/ERCXEnumerable.sol is associated with EIP 4512; because there are also changes being made to EIPS/eip-4512.md all changes to corresponding assets are also allowed

(pass) assets/eip-4512/contracts/interface/IERCX.sol

file assets/eip-4512/contracts/interface/IERCX.sol is associated with EIP 4512; because there are also changes being made to EIPS/eip-4512.md all changes to corresponding assets are also allowed

(pass) assets/eip-4512/contracts/interface/IERCXEnumerable.sol

file assets/eip-4512/contracts/interface/IERCXEnumerable.sol is associated with EIP 4512; because there are also changes being made to EIPS/eip-4512.md all changes to corresponding assets are also allowed

alita-moore · 2021-12-01T02:42:16Z

A critical exception has occurred (cc @alita-moore):
Message: can not read a block mapping entry; a multiline key may not be an implicit key at line 3, column 7:
author: kkimos [email protected]
^

Will address later

KKimos · 2021-12-01T03:20:55Z

I have been trying but I don't know what went wrong

EIPS/eip-draft_Non-Fungible Token with usage rights_abbrev.md

MicahZoltu · 2021-12-01T03:38:42Z

EIPS/eip-draft_Non-Fungible Token with usage rights_abbrev.md

+title: "Non-Fungible Token with usage rights"
+status: Draft
+type: Standards Track
+author: KKimos <[email protected]>


There must be at least one author with a GitHub account.

Suggested change

author: KKimos <[email protected]>

author: KKimos (@KKimos)

Suggested change

author: KKimos <[email protected]>

author: KKimos (@KKimos), KKimos <[email protected]>

Either of the above is acceptable.

MicahZoltu · 2021-12-01T03:39:13Z

EIPS/eip-draft_Non-Fungible Token with usage rights_abbrev.md

+## Simple Summary
+
+Separation of Non-Fungible Token ownership and usage rights , Truly in line with real life.
+


Suggested change

## Simple Summary

Separation of Non-Fungible Token ownership and usage rights , Truly in line with real life.

This section is deprecated in favor of a description header field.

MicahZoltu · 2021-12-01T03:39:58Z

EIPS/eip-draft_Non-Fungible Token with usage rights_abbrev.md

+## Reference Implementation
+
+[Github Reposotory](https://github.com/KKimos/ERCX).
+
+
+


Suggested change

## Reference Implementation

[Github Reposotory](https://github.com/KKimos/ERCX).

External links should not be used. Either inline the reference implementation, add it to ../assets/eip-4512/ or just remove this section entirely (it is optional).

Thanks for your reply. I have made changes but need to review the new ones. Do I need to submit them at once? Still waiting for review?

Co-authored-by: Micah Zoltu <[email protected]>

…ev.md to eip-4512.md

MicahZoltu · 2021-12-01T05:20:03Z

It looks like CI is passing, so you just have to wait for a review from lightclient or axic. They usually get to it within a week, but sometimes it is faster or slower.

EIPS/eip-4512.md

wschwab · 2021-12-05T09:45:17Z

There is a similar ERC also in PR right now: EIP-4400. While there are certainly differences between the two standards, I was wondering if it might be worth your time to try uniting these into one standard as opposed to two very similar ones.

wschwab

Hi! I mentioned in the PR thread that this EIP seems very similar imho to EIP-4400, and I would recommend collaborating. In the meantime, I've left some comments that I hope are helpful.

EIPS/eip-4512.md

wschwab · 2021-12-05T09:49:47Z

EIPS/eip-4512.md

+
+Different from EIP-2615, we only added a right to use, so that we can get all the functions of EIP-2615, and reduce many unnecessary operations in EIP-2615. The explanation is as follows:
+
+- The owner should not use some of the ownership rights when mortgage NFT, such as transfer, AXS-like breeding or weapon upgrade, because it is likely to change the status of the original NFT, so when the user mortgages the NFT, the ownership must be mortgaged in the contract middle.


Could you clarify what you mean by this? I suspect you're discussing a case where the owner (Alice) of an NFT is mortgaging the NFT via another party (Bob). Who is the owner now? Is Alice now theuser and Bob the owner? What is the "contract middle"?

I think is also laying down some guidelines for what a user can and cannot do, but I wasn't able to understand.

wschwab · 2021-12-05T09:50:42Z

EIPS/eip-4512.md

+Different from EIP-2615, we only added a right to use, so that we can get all the functions of EIP-2615, and reduce many unnecessary operations in EIP-2615. The explanation is as follows:
+
+- The owner should not use some of the ownership rights when mortgage NFT, such as transfer, AXS-like breeding or weapon upgrade, because it is likely to change the status of the original NFT, so when the user mortgages the NFT, the ownership must be mortgaged in the contract middle.
+- In the case of mortgage or transaction, the owner has the right to continue to use it before returning the ransom or selling it


I don't see the concept of a ransom elsewhere in the EIP. Maybe it would be beneficial if you outlined the flow of mortgaging and then paying off the mortgage of an NFT using this EIP?

wschwab · 2021-12-05T09:53:25Z

EIPS/eip-4512.md

+     * @notice Safely transfers `tokenId` tokenUser from `from` to `to`
+     * @dev If the caller is not `from`, it must be approved to move this tokenUser by {approve} or {setApprovalForAll} or {approveUser}.
+     * @param from the address token user transfer from
+     * @param to the address token user transfer to
+     * @param tokenId the NFT token's Id


imho the natspec should include the bytes4 for being an ERC4512Receiver, see, for example ERC721Receiver in EIP-721

wschwab · 2021-12-05T09:54:01Z

EIPS/eip-4512.md

+```
+
+### ERC-4512 Receiver
+


as above, imho the interface for ERC4512Receiver should be included here for reference

wschwab · 2021-12-05T09:55:58Z

EIPS/eip-4512.md

+#### 2. ERC-721
+
+Fully compatible with ERC-721
+
+```solidity
+interface ERC721{
+    event Transfer(address indexed _from, address indexed _to, uint256 indexed _tokenId);
+    event Approval(address indexed _owner, address indexed _approved, uint256 indexed _tokenId);
+    event ApprovalForAll(address indexed _owner, address indexed _operator, bool _approved);
+    function balanceOf(address _owner) external view returns (uint256);
+    function ownerOf(uint256 _tokenId) external view returns (address);
+    function safeTransferFrom(address _from, address _to, uint256 _tokenId, bytes data) external payable;
+    function safeTransferFrom(address _from, address _to, uint256 _tokenId) external payable;
+    function transferFrom(address _from, address _to, uint256 _tokenId) external payable;
+    function approve(address _approved, uint256 _tokenId) external payable;
+    function setApprovalForAll(address _operator, bool _approved) external;
+    function getApproved(uint256 _tokenId) external view returns (address);
+    function isApprovedForAll(address _owner, address _operator) external view returns (bool);
+}
+interface ERC165 {
+    function supportsInterface(bytes4 interfaceID) external view returns (bool);
+}
+```


Suggested change

#### 2. ERC-721

Fully compatible with ERC-721

```solidity

interface ERC721{

event Transfer(address indexed _from, address indexed _to, uint256 indexed _tokenId);

event Approval(address indexed _owner, address indexed _approved, uint256 indexed _tokenId);

event ApprovalForAll(address indexed _owner, address indexed _operator, bool _approved);

function balanceOf(address _owner) external view returns (uint256);

function ownerOf(uint256 _tokenId) external view returns (address);

function safeTransferFrom(address _from, address _to, uint256 _tokenId, bytes data) external payable;

function safeTransferFrom(address _from, address _to, uint256 _tokenId) external payable;

function transferFrom(address _from, address _to, uint256 _tokenId) external payable;

function approve(address _approved, uint256 _tokenId) external payable;

function setApprovalForAll(address _operator, bool _approved) external;

function getApproved(uint256 _tokenId) external view returns (address);

function isApprovedForAll(address _owner, address _operator) external view returns (bool);

}

interface ERC165 {

function supportsInterface(bytes4 interfaceID) external view returns (bool);

}

```

imho this is unnecessary

wschwab · 2021-12-05T10:00:20Z

EIPS/eip-4512.md

+#### 1 . Mortgage
+
+When mortgage NFT, you only need to mortgage the right to use into the mortgage contract, leaving the right to use.The advantage of this is that you can still use your own NFT before delivery.
+
+#### 2 . Rent 
+
+Lease does not require any collateral. First, you mortgage the NFT ownership into the contract, and the tenantry leases the right to use.
+
+This has the following benefits ：
+
+- No need to mortgage assets
+- Don't worry about the risk of default


Similar to above, I'm personally not fully understanding the intended path to leverage this EIP for NFT mortgages or rentals. The Rationale section is more for design decisions, so I don't know if this would be the right place to put it, but I think that at least for myself, if there would be more in the Motivation explaining how this EIP is intended to be leveraged, it would help me understand here.

This would also be a good section for discussing why the authors opted to create a more simplified EIP-2612, and any other alternatives that were considered but ultimately discarded in favour of the current EIP.

wschwab · 2021-12-05T10:00:53Z

EIPS/eip-4512.md

+
+## Backward compatibility
+
+This protocol is fully backward compatible with ERC721.Refer to above Specification.


Suggested change

This protocol is fully backward compatible with ERC721.Refer to above Specification.

This protocol is fully backward compatible with ERC721. Refer to the Specification section above for more details.

wschwab · 2021-12-05T10:01:47Z

EIPS/eip-4512.md

+
+
+## Test Cases
+


I don't see any tests - are there tests somewhere to run?

wschwab · 2021-12-05T10:02:38Z

EIPS/eip-4512.md

+---
+eip: 4512
+title: Non-Fungible Token with usage rights
+description: Separation of Non-Fungible Token ownership and usage rights , Truly in line with real life.


Suggested change

description: Separation of Non-Fungible Token ownership and usage rights , Truly in line with real life.

description: ERC721 NFTs with a separate user role

KKimos · 2021-12-05T10:08:21Z

fully

I tried to contact the author of EIP-4400 and request to merge with him

Co-authored-by: William Schwab <[email protected]>

lightclient · 2021-12-21T16:36:38Z

I tried to contact the author of EIP-4400 and request to merge with him

Any progress on this?

KKimos added 3 commits December 1, 2021 10:25

Create eip-draft_Non-Fungible Token with usage rights_abbrev.md

4295fa6

Merge branch 'ethereum:master' into master

87dd966

Update eip-draft_Non-Fungible Token with usage rights_abbrev.md

9c00fd9

Update eip-draft_Non-Fungible Token with usage rights_abbrev.md

e12c0ef

alita-moore mentioned this pull request Dec 1, 2021

Add custom error message for invalid YAML ethereum/EIP-Bot#34

Closed

KKimos added 4 commits December 1, 2021 10:49

Update eip-draft_Non-Fungible Token with usage rights_abbrev.md

db55c2b

Update eip-draft_Non-Fungible Token with usage rights_abbrev.md

1f6b3b3

Update eip-draft_Non-Fungible Token with usage rights_abbrev.md

54340c2

Update eip-draft_Non-Fungible Token with usage rights_abbrev.md

66e0d2f

Update eip-draft_Non-Fungible Token with usage rights_abbrev.md

0c9f061

MicahZoltu reviewed Dec 1, 2021

View reviewed changes

EIPS/eip-draft_Non-Fungible Token with usage rights_abbrev.md Outdated Show resolved Hide resolved

MicahZoltu reviewed Dec 1, 2021

View reviewed changes

EIPS/eip-draft_Non-Fungible Token with usage rights_abbrev.md Outdated Show resolved Hide resolved

MicahZoltu reviewed Dec 1, 2021

View reviewed changes

KKimos and others added 5 commits December 1, 2021 11:41

Update EIPS/eip-draft_Non-Fungible Token with usage rights_abbrev.md

923737e

Co-authored-by: Micah Zoltu <[email protected]>

Update EIPS/eip-draft_Non-Fungible Token with usage rights_abbrev.md

1022425

Co-authored-by: Micah Zoltu <[email protected]>

2021/12/01

fbb1124

Update and rename eip-draft_Non-Fungible Token with usage rights_abbr…

c6c5888

…ev.md to eip-4512.md

Update eip-4512.md

1b2093d

Update eip-4512.md

6161f6f

chee-chyuan suggested changes Dec 2, 2021

View reviewed changes

Update eip-4512.md

2a344e6

chee-chyuan reviewed Dec 3, 2021

View reviewed changes

EIPS/eip-4512.md Outdated Show resolved Hide resolved

KKimos added 2 commits December 3, 2021 10:08

Update eip-4512.md

fd285b2

Update eip-4512.md

5534381

wschwab reviewed Dec 5, 2021

View reviewed changes

KKimos and others added 3 commits December 8, 2021 10:25

Update EIPS/eip-4512.md

522e7ec

Co-authored-by: William Schwab <[email protected]>

Update ERCX.sol

23a2248

Update ERCX.sol

c604dc3

alita-moore added automerge and removed automerge labels Jan 18, 2022

github-actions bot added the stale label Mar 20, 2022

github-actions bot closed this Mar 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Non-Fungible Token with usage rights #4512

Non-Fungible Token with usage rights #4512

KKimos commented Dec 1, 2021

eth-bot commented Dec 1, 2021 •

edited

Loading

alita-moore commented Dec 1, 2021

KKimos commented Dec 1, 2021

MicahZoltu Dec 1, 2021

MicahZoltu Dec 1, 2021

MicahZoltu Dec 1, 2021

KKimos Dec 1, 2021

MicahZoltu commented Dec 1, 2021

wschwab commented Dec 5, 2021

wschwab left a comment

wschwab Dec 5, 2021

wschwab Dec 5, 2021

wschwab Dec 5, 2021

wschwab Dec 5, 2021

wschwab Dec 5, 2021

wschwab Dec 5, 2021

wschwab Dec 5, 2021

wschwab Dec 5, 2021

wschwab Dec 5, 2021

KKimos commented Dec 5, 2021

lightclient commented Dec 21, 2021

	author: KKimos <[email protected]>
	author: KKimos (@KKimos), KKimos <[email protected]>

		## Simple Summary

		Separation of Non-Fungible Token ownership and usage rights , Truly in line with real life.

		## Reference Implementation

		[Github Reposotory](https://github.com/KKimos/ERCX).


		Different from EIP-2615, we only added a right to use, so that we can get all the functions of EIP-2615, and reduce many unnecessary operations in EIP-2615. The explanation is as follows:

		- The owner should not use some of the ownership rights when mortgage NFT, such as transfer, AXS-like breeding or weapon upgrade, because it is likely to change the status of the original NFT, so when the user mortgages the NFT, the ownership must be mortgaged in the contract middle.


		## Backward compatibility

		This protocol is fully backward compatible with ERC721.Refer to above Specification.

	description: Separation of Non-Fungible Token ownership and usage rights , Truly in line with real life.
	description: ERC721 NFTs with a separate user role

Non-Fungible Token with usage rights #4512

Non-Fungible Token with usage rights #4512

Conversation

KKimos commented Dec 1, 2021

eth-bot commented Dec 1, 2021 • edited Loading

(fail) eip-4512.md

(pass) assets/eip-4512/LICENSE

(pass) assets/eip-4512/README.md

(pass) assets/eip-4512/contracts/ERCX.sol

(pass) assets/eip-4512/contracts/extensions/ERCXEnumerable.sol

(pass) assets/eip-4512/contracts/interface/IERCX.sol

(pass) assets/eip-4512/contracts/interface/IERCXEnumerable.sol

alita-moore commented Dec 1, 2021

KKimos commented Dec 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MicahZoltu commented Dec 1, 2021

wschwab commented Dec 5, 2021

wschwab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KKimos commented Dec 5, 2021

lightclient commented Dec 21, 2021

eth-bot commented Dec 1, 2021 •

edited

Loading