Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-918: Move from Stagnant to Draft #4729

Closed
wants to merge 13 commits into from
Closed

Conversation

10d9e
Copy link
Contributor

@10d9e 10d9e commented Jan 29, 2022

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Jan 29, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) EIPS/eip-918.md

classification
ambiguous
  • eip-918.md has no identifiable authors who can approve the PR (only considering the base version)

@mryalamanchi
Copy link
Contributor

@jlogelin kindly add the github username for atleast one of the author, instead of the e-mail id.

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlogelin please review EIP-1 and the EIP template. The format has changed since this EIP was created. It will need to be updated before moving it to last call.

@10d9e
Copy link
Contributor Author

10d9e commented Feb 21, 2022


(fail) EIPS/eip-918.md

classification
ambiguous
  • eip-918.md has no identifiable authors who can approve the PR (only considering the base version)
    Error: Process completed with exit code 1.

@mryalamanchi please advise

EIPS/eip-918.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@10d9e 10d9e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@10d9e 10d9e requested a review from lightclient March 3, 2022 01:38
EIPS/eip-918.md Outdated Show resolved Hide resolved
@MicahZoltu
Copy link
Contributor

./EIPS/eip-918.md:473: explicitely ==> explicitly

@MicahZoltu MicahZoltu closed this Mar 23, 2022
@MicahZoltu MicahZoltu reopened this Mar 23, 2022
@MicahZoltu
Copy link
Contributor

I verified that the author change is legitimate. You'll need to manually merge once the above spelling error is fixed and CI passes @lightclient.

EIPS/eip-918.md Outdated Show resolved Hide resolved
@lightclient
Copy link
Member

There are now merge conflicts @jlogelin can you please update so we can merge?

@github-actions github-actions bot added the stale label Jul 16, 2022
@github-actions github-actions bot removed the stale label Jul 24, 2022
@Pandapip1 Pandapip1 changed the title Update eip-918.md Update EIP-918: Move from Stagnant to Draft Sep 1, 2022
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Sep 1, 2022
@github-actions github-actions bot added the s-draft This EIP is a Draft label Sep 1, 2022
@Pandapip1
Copy link
Member

Closing since the author hasn't been seen in >3 months (the stale threshold).

@Pandapip1 Pandapip1 closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants