EIP-4841: Expandable Onchain SVG Images Storage #4841

soohanpark · 2022-02-23T08:07:21Z

We proposal an EIP, Expandable Onchain SVG Images Storage

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

Initial commit for EOSIS (Expandable Onchain SVG Images Storage Structure)

eth-bot · 2022-02-23T08:08:16Z

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) eip-4841.md

classification
`newEIPFile`

File with name EIPS/eip-4841.md is new and new files must be reviewed
This PR requires review from one of [@lightclient, @axic, @SamWilsn]

(pass) assets/eip-4841/StructureDiagram.jpg

classification
`ambiguous`

file assets/eip-4841/StructureDiagram.jpg is associated with EIP 4841; because there are also changes being made to EIPS/eip-4841.md all changes to corresponding assets are also allowed

(pass) assets/eip-4841/implementation/AssembleContract.sol

classification
`ambiguous`

file assets/eip-4841/implementation/AssembleContract.sol is associated with EIP 4841; because there are also changes being made to EIPS/eip-4841.md all changes to corresponding assets are also allowed

(pass) assets/eip-4841/implementation/IAssembleContract.sol

classification
`ambiguous`

file assets/eip-4841/implementation/IAssembleContract.sol is associated with EIP 4841; because there are also changes being made to EIPS/eip-4841.md all changes to corresponding assets are also allowed

(pass) assets/eip-4841/implementation/IStorageContract.sol

classification
`ambiguous`

file assets/eip-4841/implementation/IStorageContract.sol is associated with EIP 4841; because there are also changes being made to EIPS/eip-4841.md all changes to corresponding assets are also allowed

(pass) assets/eip-4841/implementation/PropertyContract.sol

classification
`ambiguous`

file assets/eip-4841/implementation/PropertyContract.sol is associated with EIP 4841; because there are also changes being made to EIPS/eip-4841.md all changes to corresponding assets are also allowed

(pass) assets/eip-4841/implementation/StorageContract.sol

classification
`ambiguous`

file assets/eip-4841/implementation/StorageContract.sol is associated with EIP 4841; because there are also changes being made to EIPS/eip-4841.md all changes to corresponding assets are also allowed

@Soohan-Park

EIPS/eip-4841.md

- Remove 'Structure'

soohanpark · 2022-03-04T13:15:53Z

I fixed this EIP and it was passed Travis CI now. So, could you check it again, please? 🙏
@lightclient, @axic, @SamWilsn, @MicahZoltu

soohanpark · 2022-03-10T01:09:59Z

@lightclient, @axic, @SamWilsn, @MicahZoltu - Guys, I know you're so busy, but could I ask when I can get a review for this EIP? And I always appreciate that, thx :)

MicahZoltu · 2022-03-10T10:30:47Z

I don't handle ERCs, so you'll have to wait for one of the other editors to take a look.

lightclient

Please review the following:

there are many areas of excess spacing - please only use 1-2 newlines at a time
several grammar mistakes - please ensure there are no errors
unnecessary capitalization

EIPS/eip-4841.md

soohanpark · 2022-03-19T08:41:14Z

@lightclient
I'm really appreciate for your review.
I've corrected what you suggested such as removing extra spaces and re-writing the description!
So, could you check this EIP again, please?
And, I hope you have a good day today :) Thanks for all.

lightclient

There are still errors in the EIP. Please have someone proofread it or past into an editor capable of analyzing grammar (word, google docs, etc).

EIPS/eip-4841.md

soohanpark · 2022-03-19T15:15:45Z

@lightclient, @axic, @SamWilsn
I checked grammar once again! Always thanks for your contribution.

EIPS/eip-4841.md

Pandapip1 · 2022-03-29T11:39:23Z

Personally, I prefer clarity (specifically, the ability to make a nice UX) over lower fees, but IIUC it's the decision of the authors of the EIP.

soohanpark · 2022-03-30T01:55:36Z

@Pandapip1
Thanks for your comment! I also agree to your thought.
I was confused little bit about EIP Policy(?) cause this EIP is my first suggestion 😂.

@lightclient, @axic, @SamWilsn
First, I really appreciate for your reviews. (+ Also, thanks to @MicahZoltu 😄)

In the past few days, I've been reading all of your reviews again and I thought it was necessary to refine this EIP proposal in general.
Therefore, I would like to update the contents in general by reflecting the reviews you have written, and I will ask the editor to proofreading before making a proposal.
I would like to request a review of the revised contents asap 😉

Thank you always. Have a good day today :)

lightclient · 2022-04-05T15:19:00Z

EIPS/eip-4841.md

+
+It is designed to flexibly store and utilize larger capacity SVG images by interacting with the above three layer-by-layer contracts each other.
+
+Also, you can configure the on-chain NFT images storage by adjusting the Assemble Layer's contract like below.


Suggested change

Also, you can configure the on-chain NFT images storage by adjusting the Assemble Layer's contract like below.

Also, you can configure the on-chain NFT images storage by adjusting the Assemble Layer's contract as shown below.

EIPS/eip-4841.md

lightclient · 2022-04-05T15:21:33Z

EIPS/eip-4841.md

+
+### Large Capacity Storage
+
+The best way for us to keep our content permanent and tamper-proof is to store it on Ethereum, rather than on centralized servers or IPFS, where it can be tampered with or lost. Like the SVG format, various extensions have come out to reduce the size of the content, but most of the content still has a size of several MB or more. Through this EIP, we would like to provide a solution that can safely store SVG images in sizes ranging from tens of KB to several MB on Ethereum.


Suggested change

The best way for us to keep our content permanent and tamper-proof is to store it on Ethereum, rather than on centralized servers or IPFS, where it can be tampered with or lost. Like the SVG format, various extensions have come out to reduce the size of the content, but most of the content still has a size of several MB or more. Through this EIP, we would like to provide a solution that can safely store SVG images in sizes ranging from tens of KB to several MB on Ethereum.

The best way for us to keep our content permanent and tamper-proof is to store it on Ethereum, rather than on centralized servers or IPFS, where it can be tampered with or lost. Like the SVG format, various extensions have come out to reduce the size of the content, but most of the content still has a size of several megabytes or more. Through this EIP, we would like to provide a solution that can safely store SVG images in sizes ranging from tens of KB to several MB on Ethereum.

lightclient · 2022-04-05T15:24:56Z

Before we move forward with this, I think that you need to address this piece of feedback on your magicians thread: https://ethereum-magicians.org/t/erc-4841-expandable-onchain-svg-images-storage/8410/2?u=matt

From EIP-1:

Before you begin writing a formal EIP, you should vet your idea. Ask the Ethereum community first if an idea is original to avoid wasting time on something that will be rejected based on prior research. It is thus recommended to open a discussion thread on the Ethereum Magicians forum to do this.

Once the idea has been vetted ...

soohanpark · 2022-04-06T02:41:56Z

Before we move forward with this, I think that you need to address this piece of feedback on your magicians thread: https://ethereum-magicians.org/t/erc-4841-expandable-onchain-svg-images-storage/8410/2?u=matt

@lightclient
Long time no see! And always thanks for your comment :)

We recognized the feedback on magicians thread, and I really sorry for late about comment to the feedback. We are working on improvement the overall content now.

And I replied it with improvedment Motivation section, So please check it on magians threads and feel free to leave comments.

Pandapip1 · 2022-05-13T12:48:08Z

EIPS/eip-4841.md

+
+## Copyright
+
+Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).


Suggested change

Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).

Copyright and related rights waived via [CC0](../LICENSE.md).

soohanpark · 2022-05-16T06:20:53Z

@everyone
(especially, I really thanks to @lightclient, @SamWilsn, @MicahZoltu, @Pandapip1)

We apologize for the very late reply due to our original work.

After receiving the feedback, we’ve been thinking a lot about the EIP.

We sympathize with the content of the feedback, and we have recognized that the method of storing data is difficult to establish as a standard.

And we don’t have any special ideas to replace tokenURI, so we’re going to close this EIP and this thread.
(@everyone If anyone has a good idea, it would be great to develop this EIP together!)

Thanks a lot for your feedback and interest. And we will come back with better ideas for improving Ethereum 😄

Initial Commit

8af67ea

Initial commit for EOSIS (Expandable Onchain SVG Images Storage Structure)

eth-bot added the ambiguous label Feb 23, 2022

eip-eosis => eip-4841

10ba96c

soohanpark changed the title ~~EIP-eosis: Expandable Onchain SVG Images Storage Structure~~ EIP-4841: Expandable Onchain SVG Images Storage Structure Feb 23, 2022

Add Author's Github ID

8923b69

@Soohan-Park

eth-bot added the newEIPFile label Feb 23, 2022

Change link of discussions-to

53b3e45

MicahZoltu reviewed Feb 24, 2022

View reviewed changes

EIPS/eip-4841.md Outdated Show resolved Hide resolved

EIPS/eip-4841.md Outdated Show resolved Hide resolved

Delete Simple Summary & Change to relative path

501cf92

soohanpark requested a review from MicahZoltu February 24, 2022 08:53

soohanpark added 2 commits March 4, 2022 21:38

Reduce the number of title characters

12ee798

- Remove 'Structure'

Remove EIP KR ver. file

8530689

soohanpark changed the title ~~EIP-4841: Expandable Onchain SVG Images Storage Structure~~ EIP-4841: Expandable Onchain SVG Images Storage Mar 4, 2022

Remove unneeded link

ac16483

lightclient requested changes Mar 19, 2022

View reviewed changes

EIPS/eip-4841.md Outdated Show resolved Hide resolved

EIPS/eip-4841.md Outdated Show resolved Hide resolved

soohanpark added 2 commits March 19, 2022 17:26

Remove extra spaces

e888b69

Re-write 'description' in Preamble & remove unnecesary capitalizations.

ac87a41

soohanpark requested a review from lightclient March 19, 2022 08:39

lightclient requested changes Mar 19, 2022

View reviewed changes

EIPS/eip-4841.md Outdated Show resolved Hide resolved

Check grammar

ce063bd

soohanpark requested a review from lightclient March 19, 2022 15:08

SamWilsn reviewed Mar 25, 2022

View reviewed changes

SamWilsn mentioned this pull request Mar 25, 2022

EIP-4883 Composable SVG NFT #4888

Merged

Merge branch 'ethereum:master' into master

6480696

soohanpark and others added 2 commits April 5, 2022 10:35

Merge branch 'ethereum:master' into master

69f3533

Clean-up & Remove ERC721 inheritance.

ced8c0c

lightclient requested changes Apr 5, 2022

View reviewed changes

Pandapip1 reviewed May 13, 2022

View reviewed changes

poojaranjan mentioned this pull request May 17, 2022

EIP editor apprenticeship meeting 17 ethcatherders/EIPIP#135

Closed

soohanpark closed this May 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP-4841: Expandable Onchain SVG Images Storage #4841

EIP-4841: Expandable Onchain SVG Images Storage #4841

soohanpark commented Feb 23, 2022 •

edited

Loading

eth-bot commented Feb 23, 2022 •

edited

Loading

soohanpark commented Mar 4, 2022

soohanpark commented Mar 10, 2022

MicahZoltu commented Mar 10, 2022

lightclient left a comment

soohanpark commented Mar 19, 2022

lightclient left a comment •

edited

Loading

soohanpark commented Mar 19, 2022 •

edited

Loading

Pandapip1 commented Mar 29, 2022 via email

soohanpark commented Mar 30, 2022

lightclient Apr 5, 2022

lightclient Apr 5, 2022

lightclient commented Apr 5, 2022

soohanpark commented Apr 6, 2022

Pandapip1 May 13, 2022

soohanpark commented May 16, 2022 •

edited

Loading


		It is designed to flexibly store and utilize larger capacity SVG images by interacting with the above three layer-by-layer contracts each other.

		Also, you can configure the on-chain NFT images storage by adjusting the Assemble Layer's contract like below.


		### Large Capacity Storage

		The best way for us to keep our content permanent and tamper-proof is to store it on Ethereum, rather than on centralized servers or IPFS, where it can be tampered with or lost. Like the SVG format, various extensions have come out to reduce the size of the content, but most of the content still has a size of several MB or more. Through this EIP, we would like to provide a solution that can safely store SVG images in sizes ranging from tens of KB to several MB on Ethereum.


		## Copyright

		Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).

EIP-4841: Expandable Onchain SVG Images Storage #4841

EIP-4841: Expandable Onchain SVG Images Storage #4841

Conversation

soohanpark commented Feb 23, 2022 • edited Loading

eth-bot commented Feb 23, 2022 • edited Loading

(fail) eip-4841.md

(pass) assets/eip-4841/StructureDiagram.jpg

(pass) assets/eip-4841/implementation/AssembleContract.sol

(pass) assets/eip-4841/implementation/IAssembleContract.sol

(pass) assets/eip-4841/implementation/IStorageContract.sol

(pass) assets/eip-4841/implementation/PropertyContract.sol

(pass) assets/eip-4841/implementation/StorageContract.sol

soohanpark commented Mar 4, 2022

soohanpark commented Mar 10, 2022

MicahZoltu commented Mar 10, 2022

lightclient left a comment

Choose a reason for hiding this comment

soohanpark commented Mar 19, 2022

lightclient left a comment • edited Loading

Choose a reason for hiding this comment

soohanpark commented Mar 19, 2022 • edited Loading

Pandapip1 commented Mar 29, 2022 via email

soohanpark commented Mar 30, 2022

lightclient Apr 5, 2022

Choose a reason for hiding this comment

lightclient Apr 5, 2022

Choose a reason for hiding this comment

lightclient commented Apr 5, 2022

soohanpark commented Apr 6, 2022

Pandapip1 May 13, 2022

Choose a reason for hiding this comment

soohanpark commented May 16, 2022 • edited Loading

soohanpark commented Feb 23, 2022 •

edited

Loading

eth-bot commented Feb 23, 2022 •

edited

Loading

lightclient left a comment •

edited

Loading

soohanpark commented Mar 19, 2022 •

edited

Loading

soohanpark commented May 16, 2022 •

edited

Loading