Add EIP-4910: Royalty Bearing NFTs #4910
Conversation
|
A critical exception has occurred: |
Therecanbeonlyone1969
changed the title
|
@MicahZoltu implemented all required changes. |
|
@MicahZoltu ... a gentle reminder to merge if it looks ok for you. Thank you! |
Co-authored-by: lightclient <[email protected]>
- Removed dependency on EIP-2771 - Added file with link to reference implementation since I could not add the entire reference implementation repo as a folder under assets/eip-4910
|
@lightclient @MicahZoltu ... I cannot add the reference implementation folder under Looks like the github action triggered should have the Of course, I could just add the test javascript files and the blank contracts under Would appreciate a suggestion as to how the above error can be overcome. Thank you! |
|
Your local |
I was stupid indeed ... I had forgotten that I still had another .git folder in my folder ... duh ... now it worked. It was indeed a local git issue. @MicahZoltu |
|
@MicahZoltu @lightclient ... just a gentle reminder as to the above. Have your concerns been addressed? |
|
I don't handle ERCs, you'll have to wait for one of the other editors who does handle them to get a chance to take a look. I was just providing some early feedback to help speed things along is all. |
Thank you so much @MicahZoltu ... greatly appreciated! |
Thanks @MicahZoltu. Keen to see which Editor(s) tap in. Lots of excitement building around this. |
assets/eip-4910/eip-4910-reference-implementation/contracts/PaymentModule.sol
Outdated
Show resolved
Hide resolved
- Removed all external links - Added Licensing to the header of the solidity contracts - Split Specifications and Rationales into separate section to align with EIP-1 - Intended the sections properly based on suggestion by @SamWilsn
Co-authored-by: Sam Wilson <[email protected]>
- adopted suggestion by @SamWilsn to simplify headers and remove `Rationale` headers and remove the individual `Specification` headers. - found a way to remove requirements as headers using <a name="tag_name">...</a>
* Initial Commit of Onchain Royalty Bearing NFT standard * Update to initial commit to address editor comments * Resolving figure reendering issue * Update EIPS/eip-4910.md Co-authored-by: lightclient <[email protected]> * Requested changes as per @lightclient requests from 3-22-2022 - Removed dependency on EIP-2771 - Added file with link to reference implementation since I could not add the entire reference implementation repo as a folder under assets/eip-4910 * adding reference implementation folder * Updates in response to requests by @SamWilsn - Removed all external links - Added Licensing to the header of the solidity contracts - Split Specifications and Rationales into separate section to align with EIP-1 - Intended the sections properly based on suggestion by @SamWilsn * Overlooked two external links, and removed them * Update EIPS/eip-4910.md Co-authored-by: Sam Wilson <[email protected]> * Address requested changes by @SamWilsn - adopted suggestion by @SamWilsn to simplify headers and remove `Rationale` headers and remove the individual `Specification` headers. - found a way to remove requirements as headers using <a name="tag_name">...</a> * Minor function update to adding and removing a NFT listing * Updated the functions the wrong way * Addressing Editor comment 4/22/2022 - Fixing overlooked heading corrections per comment by @SamWilsn - Minor editing in the outline section to remove some headings to simplify the flow * Update EIPS/eip-4910.md Co-authored-by: Pandapip1 <[email protected]> * Update based on discussion with @SamWilsn on 5/17 - removed specific data structure structs and just generally talked about what things are required to be held in the smart contract - consequently removed 3 requirements - removed all optional [O] and conditional [CR] requirements - removed all but 1 should [D] requirements Decision of the call was also not to split the EIP into several EIPs since that does not reduce overall complexity, and makes creating reference implementations more difficult, hurting adoption. Net effect is to noticeably reduce the size of the specification. * Missed two unhyphenated ERC references -- fixed * Fixing EIP and HTML Validator errors save for reference implementation link * added separate rationale section for the spec * fixed link for EIP-20 * fixing links * Removed reference implementation and updated relevant section in the EIP accordingly * Update EIPS/eip-4910.md Co-authored-by: Pandapip1 <[email protected]> Co-authored-by: lightclient <[email protected]> Co-authored-by: Sam Wilson <[email protected]> Co-authored-by: Pandapip1 <[email protected]>
eip: 4910
title: Royalty Bearing NFTs
description: Extension of the ERC-721 standard for NFTs to correctly define, process, and pay (hierarchical) onchain royalties from NFT sales, going beyond EIP-2981.
author: Andreas Freund (@Therecanbeonlyone1969)
discussions-to: https://ethereum-magicians.org/t/royalty-bearing-nfts/8453
status: Draft
type: Standards Track
category: ERC
created: 2022-03-14
requires: 721, 165, 2771