Create EIP-5027 #5027

qizhou · 2022-04-21T19:33:39Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

eth-bot · 2022-04-21T19:34:22Z

All tests passed; auto-merging...

(pass) eip-5027.md

classification
`updateEIP`

passed!

(pass) assets/eip-5027/0001-unlimit-code-size.patch

classification
`ambiguous`

file assets/eip-5027/0001-unlimit-code-size.patch is associated with EIP 5027; because there are also changes being made to EIPS/eip-5027.md all changes to corresponding assets are also allowed

Pandapip1

There are a few issues with this EIP - I've added comments hopefully explaining them.

EIPS/eip-5027.md

Co-authored-by: Pandapip1 <[email protected]>

EIPS/eip-5027.md

Co-authored-by: Sam Wilson <[email protected]>

MicahZoltu

A couple of minor things needed to merge as a draft, but overall seems reasonable.

EIPS/eip-5027.md

Co-authored-by: Micah Zoltu <[email protected]>

EIPS/eip-5027.md

Co-authored-by: Pandapip1 <[email protected]>

EIPS/eip-5027.md

Co-authored-by: Sam Wilson <[email protected]>

MicahZoltu

Last thing I think. Sorry I missed it the first time through.

EIPS/eip-5027.md

Co-authored-by: Micah Zoltu <[email protected]>

Add opcode number for first reference

Pandapip1

Travis CI is failing. Those issues need to be fixed, whatever they are.

MicahZoltu · 2022-05-22T04:58:38Z

./assets/eip-5027/0001-unlimit-code-size.patch:87: erro ==> error
./assets/eip-5027/0001-unlimit-code-size.patch:121: memor ==> memory

MicahZoltu · 2022-05-22T05:00:06Z

Hmm... CI is unhappy with the diff because it cuts off at a fixed number of characters. I'm not sure how to handle this generally, but for now I'm going to force merge since that is the only CI failure. I'm hoping CI doesn't fail like this every time someone touches the file.

qizhou · 2022-05-22T05:38:16Z

Hmm... CI is unhappy with the diff because it cuts off at a fixed number of characters. I'm not sure how to handle this generally, but for now I'm going to force merge since that is the only CI failure. I'm hoping CI doesn't fail like this every time someone touches the file.

Many thanks for handling this!

shemnon · 2022-05-30T03:46:33Z

EIPS/eip-5027.md

+
+## Reference Implementation
+
+The reference implementation on Geth is available at [0001-unlimit-code-size.patch](../assets/eip-5027/0001-unlimit-code-size.patch).


As far as I understand it GPL licensed code should not be in the EIP repository. Can this be changed to pointing to a commit in a pull request in Geth?

I think the external link is not recommended in the EIP repository either (as the previous version of this EIP uses the pointer to the commit).

* Create eip-tbd * Update eip-tbd * Update and rename eip-tbd to eip-5027 * Rename eip-5027 to eip-5027.md * Update eip-5027.md * Update eip-5027.md * Update EIPS/eip-5027.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5027.md Co-authored-by: Pandapip1 <[email protected]> * Update eip-5027.md * Update eip-5027.md * Update EIPS/eip-5027.md Co-authored-by: Sam Wilson <[email protected]> * Update eip-5027.md * Update EIPS/eip-5027.md Co-authored-by: Micah Zoltu <[email protected]> * add code path in assets * Update eip-5027.md * Update EIPS/eip-5027.md Co-authored-by: Pandapip1 <[email protected]> * Update EIPS/eip-5027.md Co-authored-by: Sam Wilson <[email protected]> * Update eip-5027.md * Update EIPS/eip-5027.md Co-authored-by: Micah Zoltu <[email protected]> * Update eip-5027.md Add opcode number for first reference Co-authored-by: Pandapip1 <[email protected]> Co-authored-by: Sam Wilson <[email protected]> Co-authored-by: Micah Zoltu <[email protected]> Co-authored-by: Qi Zhou <[email protected]>

qizhou added 2 commits April 21, 2022 12:29

Create eip-tbd

6d55b96

Update eip-tbd

6973e41

qizhou changed the title ~~Create EIP~~ Create EIP-5027 Apr 21, 2022

eth-bot added the ambiguous label Apr 21, 2022

qizhou added 4 commits April 21, 2022 12:37

Update and rename eip-tbd to eip-5027

0d11034

Rename eip-5027 to eip-5027.md

c50fb59

Update eip-5027.md

e189267

Update eip-5027.md

7e4ae87

Pandapip1 suggested changes Apr 22, 2022

View reviewed changes

EIPS/eip-5027.md Outdated Show resolved Hide resolved

EIPS/eip-5027.md Outdated Show resolved Hide resolved

EIPS/eip-5027.md Outdated Show resolved Hide resolved

EIPS/eip-5027.md Outdated Show resolved Hide resolved

EIPS/eip-5027.md Show resolved Hide resolved

qizhou and others added 2 commits April 22, 2022 22:53

Update EIPS/eip-5027.md

33d6a9c

Co-authored-by: Pandapip1 <[email protected]>

Update EIPS/eip-5027.md

5411bd8

Co-authored-by: Pandapip1 <[email protected]>

eth-bot added newEIPFile and removed ambiguous labels Apr 23, 2022

qizhou added 2 commits April 22, 2022 23:07

Update eip-5027.md

72237fa

Update eip-5027.md

5a8f0e2

SamWilsn requested changes Apr 29, 2022

View reviewed changes

qizhou and others added 2 commits April 30, 2022 10:01

Update EIPS/eip-5027.md

fac3df7

Co-authored-by: Sam Wilson <[email protected]>

Update eip-5027.md

175b646

poojaranjan mentioned this pull request May 3, 2022

EIP editor apprenticeship meeting 16 ethcatherders/EIPIP#124

Closed

MicahZoltu suggested changes May 6, 2022

View reviewed changes

EIPS/eip-5027.md Outdated Show resolved Hide resolved

EIPS/eip-5027.md Outdated Show resolved Hide resolved

qizhou and others added 2 commits May 6, 2022 21:51

Update EIPS/eip-5027.md

11e627f

Co-authored-by: Micah Zoltu <[email protected]>

add code path in assets

a58964e

eth-bot added the ambiguous label May 7, 2022

Update eip-5027.md

f2d9f1b

Pandapip1 reviewed May 13, 2022

View reviewed changes

EIPS/eip-5027.md Outdated Show resolved Hide resolved

Update EIPS/eip-5027.md

bdc933a

Co-authored-by: Pandapip1 <[email protected]>

poojaranjan mentioned this pull request May 17, 2022

EIP editor apprenticeship meeting 17 ethcatherders/EIPIP#135

Closed

SamWilsn reviewed May 20, 2022

View reviewed changes

EIPS/eip-5027.md Outdated Show resolved Hide resolved

Update EIPS/eip-5027.md

2200221

Co-authored-by: Sam Wilson <[email protected]>

Update eip-5027.md

99119c9

MicahZoltu suggested changes May 21, 2022

View reviewed changes

EIPS/eip-5027.md Outdated Show resolved Hide resolved

MicahZoltu reviewed May 21, 2022

View reviewed changes

EIPS/eip-5027.md Outdated Show resolved Hide resolved

qizhou and others added 2 commits May 20, 2022 21:52

Update EIPS/eip-5027.md

ce167e6

Co-authored-by: Micah Zoltu <[email protected]>

Update eip-5027.md

f985a12

Add opcode number for first reference

MicahZoltu approved these changes May 21, 2022

View reviewed changes

eth-bot added updateEIP and removed newEIPFile labels May 21, 2022

eth-bot enabled auto-merge (squash) May 21, 2022 05:01

Pandapip1 suggested changes May 21, 2022

View reviewed changes

MicahZoltu disabled auto-merge May 22, 2022 05:00

MicahZoltu merged commit ca98714 into ethereum:master May 22, 2022

shemnon reviewed May 30, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create EIP-5027 #5027

Create EIP-5027 #5027

qizhou commented Apr 21, 2022

eth-bot commented Apr 21, 2022 •

edited

Loading

Pandapip1 left a comment

MicahZoltu left a comment

MicahZoltu left a comment

Pandapip1 left a comment

MicahZoltu commented May 22, 2022

MicahZoltu commented May 22, 2022

qizhou commented May 22, 2022

shemnon May 30, 2022

qizhou May 30, 2022


		## Reference Implementation

		The reference implementation on Geth is available at [0001-unlimit-code-size.patch](../assets/eip-5027/0001-unlimit-code-size.patch).

Create EIP-5027 #5027

Create EIP-5027 #5027

Conversation

qizhou commented Apr 21, 2022

eth-bot commented Apr 21, 2022 • edited Loading

All tests passed; auto-merging...

(pass) eip-5027.md

(pass) assets/eip-5027/0001-unlimit-code-size.patch

Pandapip1 left a comment

Choose a reason for hiding this comment

MicahZoltu left a comment

Choose a reason for hiding this comment

MicahZoltu left a comment

Choose a reason for hiding this comment

Pandapip1 left a comment

Choose a reason for hiding this comment

MicahZoltu commented May 22, 2022

MicahZoltu commented May 22, 2022

qizhou commented May 22, 2022

shemnon May 30, 2022

Choose a reason for hiding this comment

qizhou May 30, 2022

Choose a reason for hiding this comment

eth-bot commented Apr 21, 2022 •

edited

Loading