Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1967: Editor revisions before Final #5061

Merged
merged 1 commit into from
May 2, 2022

Conversation

SamWilsn
Copy link
Contributor

@SamWilsn SamWilsn commented Apr 30, 2022

Hey @spalladino, @frangio, and @Amxx!

@Amxx opened a PR to move this EIP into the final state, but there were a couple blocking issues. I've taken the liberty of applying the changes, but since these go beyond just fixing typos, I'm opening this PR (and extending the last call deadline.)

I've:

  • Removed external links;
  • Moved paragraphs from "Specification" into "Rationale" as appropriate; and
  • Removed references to non-final EIPs.

If these changes are acceptable, one of the authors (@spalladino or @frangio) will need to approve.

Thanks,
Your friendly neighbourhood EIP editor.

@eth-bot
Copy link
Collaborator

eth-bot commented Apr 30, 2022

All tests passed; auto-merging...

(pass) eip-1967.md

classification
updateEIP
  • passed!

@kodiakhq kodiakhq bot merged commit 0300d08 into ethereum:master May 2, 2022
@SamWilsn SamWilsn deleted the eip-1967-formatting branch May 6, 2022 23:58
PowerStream3604 pushed a commit to PowerStream3604/EIPs that referenced this pull request May 19, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants