EIP 2400 - Tx hash URI: Move from Stagnant to Review #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct typo
Co-Authored-By: Alex Beregszaszi <[email protected]>
Co-Authored-By: Alex Beregszaszi <[email protected]>
Co-Authored-By: Alex Beregszaszi <[email protected]>
fix syntax error copied from ethereum#681 Co-Authored-By: MrChico <[email protected]>
3esmit
changed the title
Co-authored-by: Pandapip1 <[email protected]>
|
I have worked on all suggested changes by @Pandapip1 . |
SamWilsn
approved these changes
Jul 22, 2022
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
* Create eip-non_wallet_keys * Update and rename eip-non_wallet_keys to eip-non_wallet_keys.md * Update eip-non_wallet_keys.md correct typo * Update and rename eip-non_wallet_keys.md to eip-1581.md * Update eip-1581.md * Transaction Hash URI Draft * update EIP number * spellcheck * rename title, more clear semantics * grammar fix * spellcheck * fix EIP to valid * move discussions to ethereum-magicians * Update EIPS/eip-2400.md Co-Authored-By: Alex Beregszaszi <[email protected]> * Update EIPS/eip-2400.md Co-Authored-By: Alex Beregszaszi <[email protected]> * Update EIPS/eip-2400.md Co-Authored-By: Alex Beregszaszi <[email protected]> * use github usernames * Use correct term * adapt eip-831 copied text to 2400 type * fix duplicated link * add examples * better rationale * submitted transaction * better abstract * Update EIPS/eip-2400.md fix syntax error copied from ethereum#681 Co-Authored-By: MrChico <[email protected]> * tx status, err msgs, event details, + rationale * error details, some `should`s must be `must`s * spacing * fix title * fix EIP title and add 155 requirement * move to review status * Apply suggestions from code review Co-authored-by: Pandapip1 <[email protected]> * fixed links * remove references to ERC-831 * Fix references to EIP-681 * Remove references section * Remove external links from body * Rename Title "Simple Summary" to "Description" * Move use cases to motivation * Elaborate on motivation * move description from body to header * reorder header elements * reorder header element required to after created * remove reference to EIP-20 * Update title and description Co-authored-by: Bitgamma <[email protected]> Co-authored-by: Nick Johnson <[email protected]> Co-authored-by: Alex Beregszaszi <[email protected]> Co-authored-by: MrChico <[email protected]> Co-authored-by: Pandapip1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided on ethcatherders/EIPIP#149 to move it to Review process.