Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-5252: Account-bound Finance #5252

Merged
merged 113 commits into from
Sep 5, 2022
Merged

Add EIP-5252: Account-bound Finance #5252

merged 113 commits into from
Sep 5, 2022

Conversation

hskang9
Copy link
Contributor

@hskang9 hskang9 commented Jul 14, 2022

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 14, 2022

A critical exception has occurred:
Message: pr 5252 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also the CI failures.

EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
EIPS/eip-5190.md Outdated Show resolved Hide resolved
@hskang9 hskang9 changed the title EIP-5190: Account-bound Finance EIP-5252: Account-bound Finance Jul 14, 2022
EIPS/eip-5252.md Outdated Show resolved Hide resolved
EIPS/eip-5252.md Outdated Show resolved Hide resolved
EIPS/eip-5252.md Outdated Show resolved Hide resolved
EIPS/eip-5252.md Outdated Show resolved Hide resolved
EIPS/eip-5252.md Outdated Show resolved Hide resolved
EIPS/eip-5252.md Outdated Show resolved Hide resolved
EIPS/eip-5252.md Outdated Show resolved Hide resolved
EIPS/eip-5252.md Outdated Show resolved Hide resolved
EIPS/eip-5252.md Outdated Show resolved Hide resolved
hskang9 and others added 5 commits July 20, 2022 16:59
@github-actions
Copy link

The commit 2b3f246 (as a parent of ee58e8f) contains errors. Please inspect the Run Summary for details.

@hskang9 hskang9 requested review from MicahZoltu and xinbenlv and removed request for MicahZoltu September 3, 2022 18:44
@hskang9
Copy link
Contributor Author

hskang9 commented Sep 4, 2022

@xinbenlv Is there anything that needs to be done in the general interface?

@Pandapip1
Copy link
Member

There isn't anything more that needs to be done. @eth-bot is borking. Let me re-run it.

Pandapip1
Pandapip1 previously approved these changes Sep 5, 2022
@eth-bot eth-bot merged commit 60fa745 into ethereum:master Sep 5, 2022
@hskang9
Copy link
Contributor Author

hskang9 commented Sep 11, 2022

@Pandapip1 @MicahZoltu @xinbenlv I would be appreciated for the next steps to finalize this EIP.

@Pandapip1
Copy link
Member

The next step before moving an EIP to review is to solicit feedback. Tell people on the internet who might be interested in your EIP. Ask them to review it and provide feedback. After you feel like you've asked enough people, submit a PR that makes those changes and moves the EIP to review.

@hskang9
Copy link
Contributor Author

hskang9 commented Sep 20, 2022

Can someone help me on asking solicit feedback? What place is the right place to ask for review? @Pandapip1 @MicahZoltu @xinbenlv

@hskang9
Copy link
Contributor Author

hskang9 commented Sep 20, 2022

Can I get help on where to share this for asking solicit feedback? @Pandapip1 @MicahZoltu @xinbenlv @SamWilsn

@Pandapip1
Copy link
Member

Can I get help on where to share this for asking solicit feedback? @Pandapip1 @MicahZoltu @xinbenlv @SamWilsn

Micah is no longer an EIP editor and probably doesn't want to be pinged.

Unfortunately, I actually have no idea of what makes a good place to solicit feedback. The ECH discord (linked to in the README) is probably a good place to start. Making your own blog posts is probably also a good idea, as it allows you to delve more into the motivation behind the EIP and some more interesting use cases.

When you share your EIP, you should link both to the EIP itself (https://eips.ethereum.org/EIPS/eip-5252) and the discussions-to link (https://ethereum-magicians.org/t/pr-5252-discussion-account-bound-finance/10027).

Good luck!

P.S. I am more than happy to help contribute to this EIP. Would you like me to submit a PR to make some changes I feel could be usefully made?

@MicahZoltu
Copy link
Contributor

Ironically, your quote of the message that mentioned me caused me to be re-subscribed after having unsubscribed after hskang9's comment. 😆

@hskang9
Copy link
Contributor Author

hskang9 commented Dec 13, 2022

After time passed while tracking Do Kwon and other bonanza things going on in crypto, @MicahZoltu I think @Pandapip1 is just talking bullshit and avoiding the responsibility to make solicit feedback. Can I just ask you to review? and is even ethereum magicians an active forum to get feedback? @Pandapip1 are you like SBF where you say you don't know when you have responsibility as an editor?

@hskang9
Copy link
Contributor Author

hskang9 commented Dec 13, 2022

@MicahZoltu I guess to look for feedback, I need to give feedback as well. @Pandapip1 I should go back to your every proposal on EIP to give solicit feedback on technical feasibility and actual usability. I don't want this place to be a bunch of stargazers with autism who can just propose idea because it is just cool and their parents like it, so I will do my best to contribute to shut them down.

@Pandapip1
Copy link
Member

Pandapip1 commented Dec 13, 2022

Editors have a responsibility to ensure quality, and to make the process as open and fair as possible to the most amount of people.

Quite frankly, your EIP draft was lower-quality than most incoming drafts while being 10x the size. You should be thankful that I took the time to review it and make constructive suggestions, rather than ignore it due to its numerous flaws and excessive bloat.

Neither your meritless allegations of xenophobia and plagiarism, nor your combative responses helped endear me to you. So you're right, I should focus on my responsibilities. You're on your own now. The process is well-documented at EIP-1. I wish you the best of luck.

nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* add eip-5190

* Update eip-5190.md

* Update eip-5190.md

* Update eip-5190.md

* Update eip-5190.md

* update eip-5190.md

* update eip-5190.md

* Update EIPS/eip-5190.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5190.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5190.md

Co-authored-by: Micah Zoltu <[email protected]>

* Update EIPS/eip-5190.md

Co-authored-by: Micah Zoltu <[email protected]>

* Update EIPS/eip-5190.md

Co-authored-by: Micah Zoltu <[email protected]>

* Update EIPS/eip-5190.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5190.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5190.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5190.md

Co-authored-by: Pandapip1 <[email protected]>

* Update and rename eip-5190.md to eip-5252.md

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* update eip-5252.md

* update eip-5252.md

* update eip-5252.md

* update eip-5252.md

* update eip-5252.md

* update eip-5252.md

* update eip-5252.md

* update eip-5252.md

* update eip-5252.md

* add details on abt governance

* update eip-5252

* update eip-5252 contracts

* update eip-5252

* add rationale and security consideration section

* eip-5252 rationale

* update eip-5252

* add .gitignore

* update eip-5252

* update eip5252

* update eip5252

* update eip5252

* Update assets/eip-5252/contracts/ABT.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/ERC721A.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/Finance.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/ERC721A.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/Factory.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update README.md

* update eip-5252.md

* Update EIPS/eip-5252.md

Co-authored-by: xinbenlv <[email protected]>

* add requirements for interaction

* add properties for global functions

* add requirement keywords to the specification

* add SHALL

* add requirements

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/.gitignore

Co-authored-by: Pandapip1 <[email protected]>

* update contracts

* update gitignore

* update influencer

* add citation

* remove citation

* Update assets/eip-5252/contracts/Manager.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/interfaces/IFactory.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/interfaces/IABT.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/interfaces/IManager.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update eip-5252.md

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/interfaces/IFactory.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/interfaces/IABT.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/interfaces/IFinance.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/interfaces/IFinance.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update assets/eip-5252/contracts/governance/Governor.sol

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5252.md

Co-authored-by: Pandapip1 <[email protected]>

* Delete empty file

* Delete second empty file

* Apply suggestions from code review

* add clarification in motivation section

* Fix a few issues

* remove .DS_Store

Co-authored-by: Hyungsuk Kang <[email protected]>
Co-authored-by: Pandapip1 <[email protected]>
Co-authored-by: Micah Zoltu <[email protected]>
Co-authored-by: xinbenlv <[email protected]>
@hskang9
Copy link
Contributor Author

hskang9 commented Mar 30, 2023

@Pandapip1 Your comment on this proposal sounds like you just hate a person and his proposal, and you glorify your privilege on being an EIP editor. All of my actions are defense of my right as an EIP proposer from a pathological narcissist who attempts to bend the rule and take over the system in his personal favor. Your responsibility is to review all EIPs as an editor in the rule, not to personally evaluate them based on your cultural, racial background. Your contribution on reviewing this EIP is not really found except picking up grammatical nuance by your perspective, and you are neglecting the fact that @MicahZoltu and @SamWilsn
actually reviewed this and didn't complain about the quality. In fact, I do not understand why this proposal has lower quality from a person who hasn't even coded in solidity in his professional career. Isn't a proposal in better quality if there are more details and more contracts to declare its precise design? If I compare my proposal to your proposal, none of your proposal is feasible and have zero code implementation. But who cares, @vbuterin chose you as an EIP editor. That's what matters for you, right? You judge people low-quality because you are an EIP editor at the end of the day. I guess this community considers the quality based on how close the one is to Ethereum Foundation? If it is, why not make an orgy dorm and start competing each other who has the highest quality of oneself just like FTX? I consider your quotes as gibberish as you never had a related career in the proposal except this voluntary job, but I respect your correction to put your narcissism away and finally state that you focus on your one sole job. Doing something at its best is respectful.

@hskang9
Copy link
Contributor Author

hskang9 commented Mar 30, 2023

To be honest, this is absurd lol. An EIP editor saying that a proposal is low-quality because he just does not like the sentences while he can't read a Solidity code nor even make implementation on his idea. Yet, he still says he had done something for good based on his personal feeling...

Neither your meritless allegations of [xenophobia](https://twitter.com/hyungsuk_k/status/1547695380359692288) and [plagiarism](https://twitter.com/hyungsuk_k/status/1550976727912181760), nor your combative responses helped endear me to you.

If you are saying the allegations are meritless, you are repeating the same quote that previous TFL employees were saying. I didn't give up my allegations until I said to medias and law enforcements for 1 year, and now they are in jail for what they felt worthless before. As I said their actions are wrong to public, and it has become a great source of facts to track evidences to their sins. I hope to see you face the same consequences as I try to connect medias and networks as well to know about you. Your attitude towards people are disgusting as you do not seem to treat other people as same. As you talk about "merit", you seem to believe in your deep heart's content that the justice is only for the strong regardless of rules. I do not understand why you stalk my twitter profile, but sharing the tweet is not about general public to see the post unlike your feelings. It is for the networks of people tracking down disgusting bad actors in this industry like you. As you pretend to walk away and focus on your feelings without actual thought, I will take my chances to get clarification and solution for this nonsense no matter how long it takes.

Also, did you just say "endear me"..? This quote is never an attitude from a public organization should have. If it is, Ethereum Foundation is a private entity, and @Pandapip1 is the CEO who can give endless benefit if one is close to him like Do Kwon. At the end of the day, this EIP goes on, not because you liked it or not, neither in high or low quality, it just had an minimal code and explanation just like every other proposers unlike yours. You do not have a right to say about a quality of a proposal when you can't even make a valid one with actually working code. A honest feedback is what I seek for, not your personal "feelings" or opinion on quality. As I say again, I protect my right as an EIP proposer. I share this tweet to publicize this problem. https://twitter.com/hyungsuk_k/status/1641547535343812615?s=20 You can still undervalue my freedom of speech I have with your unworthy status as an EIP editor earned from brown nosing your owners. Fathers of your nation despise you, such a shame.

@hskang9
Copy link
Contributor Author

hskang9 commented Mar 30, 2023

@vbuterin @MicahZoltu @SamWilsn can I and @smuxx get a proper amen on this ERC review?

@ethereum ethereum locked as too heated and limited conversation to collaborators Mar 31, 2023
@SamWilsn
Copy link
Contributor

This pull request has been merged. Please continue any discussion on the technical merits of the proposal on its discussion thread and any other comments on relevant pull requests. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants