Update EIP-1: Add License Checker #5379
Conversation
File
|
|
The commit 51a20de (as a parent of 67d67c4) contains errors. Please inspect the Run Summary for details. |
|
Testing... |
|
Well uh, glad I tested 😆 |
|
The commit 12f8113 (as a parent of 13d8664) contains errors. Please inspect the Run Summary for details. |
|
Well, I guess I'm about to be adding some identifiers to a few files. This will now need a manual merge. |
|
Actually, on second thought, I'll just exempt those files. |
|
The commit 12f8113 (as a parent of 272a89a) contains errors. Please inspect the Run Summary for details. |
|
The commit 533d083 (as a parent of 0aebd8f) contains errors. Please inspect the Run Summary for details. |
|
|
No, it does, but IIRC the solidity compiler warns you if you don't have a license file, as if it's deployed to Ethereum and the contract source verified, the license should be obvious from the file alone. That's my case for |
|
Is it possible to make it so it checks to make sure licenses are CC0 if present, but ignore the file if they aren't present? That would be my preference if it is possible. |
Again, that's explicitly not allowed by the solidity style guide. I'd be glad to make an issue if it's a blocker, but I would much rather force people to do the right thing and make it obvious that their code can be used for whatever purpose. |
We are not beholden to following other people's bad decisions just because they write them down in a style guide. 😄 The argument that the license should be embedded in the contract so that it shows up in various tools that deterministically build based on the source file alone (like Etherscan) is a much more compelling argument in favor of including a license in the header, so I recommend you pursue that angle rather than "because other people do it".
Aside from the Ethesrcan argument above, I'm very much unconvinced this practice is "the right thing" and in almost all other contexts I think it is "the wrong thing". All the above being said, I think I'm compelled enough by the Etherscan issue to allow this for .sol files, though I would still like licenses to not be required for other file types as I consider it to be an |
|
I can get behind not requiring licenses in other files (after all, most of the issues with using the wrong license are in .sol files due to most developers automatically putting in the MIT license header in their .sol files). I have already made that change. |
|
The commit d261332 (as a parent of 125c7d5) contains errors. Please inspect the Run Summary for details. |
|
Re-requesting @SamWilsn |
Pandapip1
requested review from
MicahZoltu and
xinbenlv
and removed request for
MicahZoltu
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
Re-cc @SamWilsn |
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
CC @SamWilsn |
|
@Pandapip1 I assume you're pinging me just to keep the stale bot away, but I won't approve a PR that only allows |
|
As discussed on EIPIP today, I've opened a discussion thread about licenses: https://ethereum-magicians.org/t/14329 |
This was something I was not aware of. Would you mind telling me which licenses can be allowed? |
|
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
I think we can start with |
|
I didn't know there was a FEM thread. I'll add the non-copyleft ones for now. |
|
Also, I assume you mean Unilicence as opposed to Unlicenced? |
|
The license checker isn't sophisticated enough to do SPDX checking. I'll probably make my own CI tool. |
|
The commit 7568e6d (as a parent of 2b45aaf) contains errors. |
Makes sure all solidity files are CC0.