Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECH Discord Channel to EIP Page Index #5415

Merged
merged 8 commits into from
Aug 23, 2022
Merged

Add ECH Discord Channel to EIP Page Index #5415

merged 8 commits into from
Aug 23, 2022

Conversation

xinbenlv
Copy link
Contributor

@xinbenlv xinbenlv commented Aug 4, 2022 •
edited
Loading

See preview here: https://xinbenlv.github.io/EIPs

Old

2022-08-17_21-31-48

New

2022-08-17_21-31-34

@eth-bot eth-bot enabled auto-merge (squash) August 4, 2022 19:55
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 4, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 5415 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

The commit b6d2aa4 (as a parent of 4d4fe83) contains errors. Please inspect the Run Summary for details.

@xinbenlv
Copy link
Contributor Author

xinbenlv commented Aug 4, 2022

What's the best way to preview this change?

@Pandapip1
Copy link
Member

Set the github pages branch to patch-21 in your fork.

Pandapip1
Pandapip1 suggested changes Aug 6, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the ambiguous label Aug 8, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

The commit 3c6dd10 (as a parent of a939117) contains errors. Please inspect the Run Summary for details.

This was referenced Aug 9, 2022
Closed
Closed
lightclient
lightclient reviewed Aug 10, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
auto-merge was automatically disabled August 14, 2022 02:51

Head branch was pushed to by a user without write access

@xinbenlv xinbenlv requested a review from eth-bot as a code owner August 14, 2022 02:51
@xinbenlv @Pandapip1
Update index.html
bcac90d 
Co-authored-by: Pandapip1 <[email protected]>
@xinbenlv
Copy link
Contributor Author

Set the github pages branch to patch-21 in your fork.

Is there a link I can take a look directly without configuration? Or do I have to compile the github-pages locally?

@Pandapip1
Copy link
Member

Just set the GH pages branch in your fork settings. No other action is needed.

@xinbenlv xinbenlv dismissed a stale review via 2a59570 August 18, 2022 01:21
@xinbenlv
Copy link
Contributor Author

xinbenlv commented Aug 18, 2022 •
edited
Loading

See preview in http://xinbenlv.github.io/EIPs

Old

2022-08-17_21-31-48

New

2022-08-17_21-31-34

@xinbenlv
Copy link
Contributor Author

Merging is blocked by unrelated errors.
2022-08-18_08-32-08

@Pandapip1
Copy link
Member

Pandapip1 commented Aug 18, 2022 •
edited
Loading

Yes. Please close and re-open this PR to apply the fixed settings.

@SamWilsn SamWilsn closed this Aug 18, 2022
@SamWilsn SamWilsn reopened this Aug 18, 2022
Pandapip1
Pandapip1 approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamWilsn please approve (this PR needs 2 approvals)

@xinbenlv
Copy link
Contributor Author

Merged with origin/master to update the branch

@xinbenlv
Copy link
Contributor Author

@Pandapip1 @SamWilsn reapprove?

@poojaranjan poojaranjan mentioned this pull request Aug 23, 2022
Closed
@eth-bot eth-bot enabled auto-merge (squash) August 23, 2022 15:23
@eth-bot eth-bot merged commit a024063 into ethereum:master Aug 23, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@xinbenlv @Pandapip1 @nachomazzara
Add ECH Discord Channel to EIP Page Index (ethereum#5415)
c23d64b 
* Add ECH Discord Channel to EIP Page Index

* Update index.html

Co-authored-by: Pandapip1 <[email protected]>

* Update index.html

Co-authored-by: Pandapip1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@lightclient lightclient Awaiting requested review from lightclient

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xinbenlv @eth-bot @Pandapip1 @lightclient @SamWilsn