-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-2681: Minor clarification #5434
Conversation
@axic: I was minorly confused by the wording so I propose some clarification.. Change from ``` Limit account nonce to be between `0` and `2^64-1`. ``` to Option 1 ``` Limit account nonce to be between `0` and `2^64-1`(inclusive). ``` or Option 2 ``` Limit account nonce to be `0<=account_nonce<=2^64-1` ``` to clarify in the summary the inclusivity of two ends
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) eip-2681.md
|
The commit 005fe3b (as a parent of 1232e53) contains errors. Please inspect the Run Summary for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I, personally, am fine with this change. It only changes the abstract and introduces a useful clarification.
Thank you. Since there is no concern on the editor side, I will leave it to the author to make a choice of the 3 options or leave it as-is: @axic |
Head branch was pushed to by a user without write access
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Friendly ping author @axic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer option 2 over option 1, but generally don't think a change is necessary here.
Thanks @lightclient. I like option 2 better too. I was personally confused by original wording hence the PR. Let's see if @axic think needed? I am ok either way. |
@axic friendly ping for author approval. Or let me know if this PR is useful or shall be dropped |
EIPS/eip-2681.md
Outdated
@@ -1,6 +1,7 @@ | |||
--- | |||
eip: 2681 | |||
title: Limit account nonce to 2^64-1 | |||
description: Limit account nonce to be between `0` and `2^64-1`(inclusive). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inclusive
wording is materially incorrect.
The specification states:
- Consider any transaction invalid, where the nonce exceeds or equals to
2^64-1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes you are right. (embarrassed... I was such an idiot T.T ....)
Updated to 0<=account_nonce<2^64-1
.
Please feel free to reject this PR and I will withdraw if you think this is not necessary. @axic
The bot states only:
I wonder if it is not displaying the warning anymore that this is modifying a |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
@axic: I was minorly confused by the wording so I propose some clarification..
Change from
to Option 1
or Option 2
to clarify in the summary the inclusivity of two ends