Add EIP-5748: Approval Expiration for EIP-20 Tokens #5748

Mr-Lucky · 2022-10-04T15:31:54Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

eth-bot · 2022-10-04T15:33:05Z

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) eip-5748.md

classification
`newEIPFile`

File with name EIPS/eip-5748.md is new and new files must be reviewed
This PR requires review from one of [@lightclient, @axic, @SamWilsn, @Pandapip1]

(pass) assets/eip-5748/eip-5748.sol

classification
`ambiguous`

file assets/eip-5748/eip-5748.sol is associated with EIP 5748; because there are also changes being made to EIPS/eip-5748.md all changes to corresponding assets are also allowed

BigBro17on25tolife · 2022-10-04T15:59:42Z

Hey lucky, I’m still getting up to speed on the language and adaptability on how to use in my projects. Please excuse my absence. If you have any tips on how to catch up as fast as I can, please advise

…

Sent from my iPhone

On Oct 4, 2022, at 8:34 AM, eth-bot ***@***.***> wrote: Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) EIPS/eip-draft_erc20_approval_expiration.md classification ambiguous file 'EIPS/eip-draft_erc20_approval_expiration.md' is not a valid eip file name; all eip files need to be in eip-####.md format. It's assumed however that this has been included because an eip number has not been provided for this eip yet. cc @***@***.******@***.******@***.******@***.*** (fail) assets/eip-draft_erc20_approval_expiration/erc20-approval-expiration.sol classification ambiguous 'assets/eip-draft_erc20_approval_expiration/erc20-approval-expiration.sol' must be in eip-###.md format; this error will be overwritten upon relevant editor approval — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

EIPS/eip-draft_erc20_approval_expiration.md

lightclient · 2022-10-05T13:49:34Z

EIPS/eip-draft_erc20_approval_expiration.md

+eip: <to be assigned>
+title: Approval Expirations for ERC20 Tokens
+description: This standard introduces a standardized way for users to set expiration limits on ERC-20 token approvals.
+author: Go+ Security <@GoPlusSecurity>, Jeff Hall <@JeffHal25193696>, Xavi <@XaaaaavitheFool>, Turan Vural <@turanzv>


Github names need to be wrapped in parentheses like this lightclient (@lightclient).

Should be reviewed. There is a problem between the account and management account is being reviewed

Approval Expirations for ERC20 Tokens -> Approval Expiration for ERC-20 Tokens Co-authored-by: lightclient <[email protected]>

Co-authored-by: lightclient <[email protected]>

turanzv · 2022-10-07T01:38:43Z

@lightclient we're hitting CI failures with the "EIP Walidator". Our references to ERC-20 are being flagged as violations. Should we be referring to ERC-20 as EIP-20?

EIPS/eip-5748.md

Co-authored-by: Sam Wilson <[email protected]>

Pandapip1 · 2022-11-16T14:52:04Z

assets/eip-5748/eip-5748.sol

@@ -0,0 +1,557 @@
+// SPDX-License-Identifier: MIT


Must be CC0.

refactor and adding interface

jdbertron · 2022-12-16T07:54:29Z

EIPS/eip-5748.md

+
+So that existing event statistics are not perturbed by the implementation of this standard, `_approve()` is triggered by the new event `AllowanceExpireTimeUpdated()`.
+
+This standard is absolutely compatible with the traditional [EIP-20](./eip-20.md) standard. `DEFAULT_EXPIRATION` is added so that the original `approve(address spender, uint256 amount)` method header can remain for backwards compatibility and ease of programming. `DEFAULT_EXPIRATION` can be set to a constant or variable according to the developer's needs.


Can we know this is 'absolutely compatible' ?

SamWilsn · 2022-12-09T18:02:23Z

EIPS/eip-5748.md

+
+## Abstract
+
+This standard adds an expiration time to the `_approve()` function of token contracts to automatically recall approvals within a certain time period. This functionality as a standard will prevent vulnerabilty exploits due to outstanding token approvals.


Where is this _approve coming from?

I suspect _approve comes from a well known EIP-721 implementation? The standard itself doesn't define it.

github-actions · 2023-01-25T00:19:07Z

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions · 2023-03-08T00:19:42Z

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

amirkhan7javi · 2023-07-02T16:28:53Z

Should be reviewed. There is a problem between the account and management account is being reviewed

commit draft erc20 approval exxpiration

7781c2c

Mr-Lucky requested a review from eth-bot as a code owner October 4, 2022 15:31

github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft labels Oct 4, 2022

Mr-Lucky changed the title ~~add eip-draft_erc20_approval_exxpiration~~ add eip-draft_erc20_approval_expiration Oct 4, 2022

turanzv and others added 4 commits October 5, 2022 00:30

general edits

83890f9

replace EIP with standard

fd971da

Merge branch 'ethereum:master' into master

9127219

fix amount of lost currency

3ef9e71

lightclient requested changes Oct 5, 2022

View reviewed changes

turanzv and others added 2 commits October 6, 2022 18:19

Update EIPS/eip-draft_erc20_approval_expiration.md

0556b62

Approval Expirations for ERC20 Tokens -> Approval Expiration for ERC-20 Tokens Co-authored-by: lightclient <[email protected]>

adding eip number

6b9c8f5

Co-authored-by: lightclient <[email protected]>

github-actions bot removed the e-number Waiting on EIP Number assignment label Oct 7, 2022

turanzv added 6 commits October 6, 2022 18:23

rename files to eip number

314bccc

Merge branch 'master' of github.com:GoPlusSecurity/EIPs

7b6cb76

fix contact info

aed99f0

fix ERC references to comply w/ ERC-### format

c5817f1

fix ERC references to comply w/ ERC-### format

51d77b1

add discussions-to

a7d068a

turanzv added 4 commits October 6, 2022 19:04

edit contact info

f756e39

updte discussion forum

b74515a

update discussion forum

506bdff

editing header

93fa230

github-actions bot added the t-interface label Oct 7, 2022

Pandapip1 changed the title ~~add eip-draft_erc20_approval_expiration~~ Add EIP-5748: Approval Expiration for EIP-20 Tokens Oct 7, 2022

Pandapip1 reviewed Oct 7, 2022

View reviewed changes

EIPS/eip-5748.md Outdated Show resolved Hide resolved

turanzv and others added 8 commits October 23, 2022 21:22

Update EIPS/eip-5748.md

470912b

Co-authored-by: Sam Wilson <[email protected]>

Update EIPS/eip-5748.md

b0183f0

Co-authored-by: Sam Wilson <[email protected]>

Update EIPS/eip-5748.md

d9ffc78

Co-authored-by: Sam Wilson <[email protected]>

Update EIPS/eip-5748.md

96dc083

Co-authored-by: Sam Wilson <[email protected]>

corrected discussions-to link

8db8319

Remove pre-abstract text

df609c6

Co-authored-by: Sam Wilson <[email protected]>

Correct tone in Specification section

9a368a2

Co-authored-by: Sam Wilson <[email protected]>

adding @xyfidea to authors

77bc9b3

poojaranjan mentioned this pull request Nov 1, 2022

EIP Editing Office Hour Meeting 5 ethcatherders/EIPIP#186

Closed

turanzv added 5 commits November 2, 2022 18:20

moving snippet from rationale to Backwards Compatibility

a11982f

fixing ERC-20 references re @Ballestar

86cc023

fixing markdown linting

836dc7e

adding links to ERCs in repo

6fde6e8

changing ERC references to ERC b/c 'EIP Walidator'

1846db3

This comment was marked as spam.

Sign in to view

poojaranjan mentioned this pull request Nov 11, 2022

EIP Editing Office Hour Meeting 6 ethcatherders/EIPIP#188

Closed

refactor and adding interface

abfe631

Pandapip1 reviewed Nov 16, 2022

View reviewed changes

assets/eip-5748/eip-5748.sol Outdated

@@ -0,0 +1,557 @@

// SPDX-License-Identifier: MIT

Copy link

Member

Pandapip1 Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be CC0.

turanzv and others added 2 commits December 15, 2022 21:28

Merge pull request #2 from ballestar/master

84631f1

refactor and adding interface

adding @Ballestar to contributors

5459e2f

jdbertron reviewed Dec 16, 2022

View reviewed changes

SamWilsn reviewed Dec 16, 2022

View reviewed changes

turanzv added 2 commits December 27, 2022 02:34

fixing license on .sol asset

d098211

fixing @Ballestar annotation

a1e8bb8

poojaranjan mentioned this pull request Jan 9, 2023

EIP Editing Office Hour Meeting 10 ethcatherders/EIPIP#204

Closed

25 tasks

github-actions bot added the w-stale Waiting on activity label Jan 25, 2023

github-actions bot closed this Mar 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP-5748: Approval Expiration for EIP-20 Tokens #5748

Add EIP-5748: Approval Expiration for EIP-20 Tokens #5748

Mr-Lucky commented Oct 4, 2022

eth-bot commented Oct 4, 2022 •

edited

Loading

BigBro17on25tolife commented Oct 4, 2022 via email

lightclient Oct 5, 2022

turanzv Oct 7, 2022

amirkhan7javi Jul 2, 2023

turanzv commented Oct 7, 2022

This comment was marked as spam.

Pandapip1 Nov 16, 2022

jdbertron Dec 16, 2022

SamWilsn Dec 9, 2022

SamWilsn Jan 10, 2023

github-actions bot commented Jan 25, 2023

github-actions bot commented Mar 8, 2023

amirkhan7javi commented Jul 2, 2023


		So that existing event statistics are not perturbed by the implementation of this standard, `_approve()` is triggered by the new event `AllowanceExpireTimeUpdated()`.

		This standard is absolutely compatible with the traditional [EIP-20](./eip-20.md) standard. `DEFAULT_EXPIRATION` is added so that the original `approve(address spender, uint256 amount)` method header can remain for backwards compatibility and ease of programming. `DEFAULT_EXPIRATION` can be set to a constant or variable according to the developer's needs.


		## Abstract

		This standard adds an expiration time to the `_approve()` function of token contracts to automatically recall approvals within a certain time period. This functionality as a standard will prevent vulnerabilty exploits due to outstanding token approvals.

Add EIP-5748: Approval Expiration for EIP-20 Tokens #5748

Add EIP-5748: Approval Expiration for EIP-20 Tokens #5748

Conversation

Mr-Lucky commented Oct 4, 2022

eth-bot commented Oct 4, 2022 • edited Loading

(fail) eip-5748.md

(pass) assets/eip-5748/eip-5748.sol

BigBro17on25tolife commented Oct 4, 2022 via email

lightclient Oct 5, 2022

Choose a reason for hiding this comment

turanzv Oct 7, 2022

Choose a reason for hiding this comment

amirkhan7javi Jul 2, 2023

Choose a reason for hiding this comment

turanzv commented Oct 7, 2022

This comment was marked as spam.

Pandapip1 Nov 16, 2022

Choose a reason for hiding this comment

jdbertron Dec 16, 2022

Choose a reason for hiding this comment

SamWilsn Dec 9, 2022

Choose a reason for hiding this comment

SamWilsn Jan 10, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 25, 2023

github-actions bot commented Mar 8, 2023

amirkhan7javi commented Jul 2, 2023

eth-bot commented Oct 4, 2022 •

edited

Loading