Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5380: Move to Review #6187

Closed
wants to merge 2 commits into from
Closed

Update EIP-5380: Move to Review #6187

wants to merge 2 commits into from

Conversation

Pandapip1
Copy link
Member

No description provided.

@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Dec 20, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 20, 2022 •
edited
Loading

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) .gitignore

classification
ambiguous
  • '.gitignore' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

(fail) eip-3540.md

classification
updateEIP

(fail) eip-3670.md

classification
updateEIP

(fail) eip-4200.md

classification
updateEIP

(fail) eip-4337.md

classification
updateEIP

(fail) eip-4750.md

classification
updateEIP

(fail) eip-5115.md

classification
updateEIP

(fail) eip-5219.md

classification
statusChange
  • eip-5219 state was changed from draft to review
  • This PR requires review from one of [@axic, @SamWilsn]

(fail) eip-5380.md

classification
statusChange
  • eip-5380 state was changed from draft to review
  • This PR requires review from one of [@axic, @SamWilsn]

(fail) eip-5450.md

classification
updateEIP

(pass) eip-5507.md

classification
updateEIP
  • passed!

(fail) eip-5568.md

classification
statusChange

(fail) eip-5606.md

classification
updateEIP

(fail) eip-5773.md

classification
updateEIP

(fail) eip-6110.md

classification
updateEIP

(fail) eip-6170.md

classification
updateEIP

(fail) eip-6206.md

classification
updateEIP

(pass) assets/eip-5773/contracts/MultiAssetToken.sol

classification
ambiguous
  • file assets/eip-5773/contracts/MultiAssetToken.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/test/multiasset.ts

classification
ambiguous
  • file assets/eip-5773/test/multiasset.ts is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

@ethereum ethereum deleted a comment from sangnguyen696969 Dec 22, 2022
@ethereum ethereum deleted a comment from sangnguyen696969 Dec 22, 2022
SamWilsn
SamWilsn reviewed Dec 25, 2022
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please compute the interface ids and mention them in the proposal.

Are you okay moving into review without the security considerations section filled out?

@Pandapip1
Copy link
Member Author

Are you okay moving into review without the security considerations section filled out?

Thanks for reminding me. I'll fix that.

@Pandapip1 @mkalinin
@djrtwo @lightclient @gumb0 @jochem-brouwer @chfast @shemnon @steven2308 @ThunderDeliverer @ayobuenavista @leekt @sujithsomraaj @mattstam @gaurangtorvekar @SamWilsn
Merge master into eip-5380-review (#6215)
4acd66b 
* Add EIP-6110: Supply validator deposits on chain (#6110)

* EIP-6110: initial draft

* Fix header

* Fill out the discussions-to

* Make linter happy

* Fix color schema for python snippets

* Apply suggestions from code review

Co-authored-by: Danny Ryan <[email protected]>

* Fix anchor

* Fix eip4881 link

* Fix eip4881 link once again

Co-authored-by: Danny Ryan <[email protected]>

* Update EIP-5507: Fix typo (wei is a reserved name) (#6191)

* 3540,4570,5450: update EOF container format (#6156)

* 3540: update eof contain format

* 4750,5450: update for new 3540 changes, disallow unreachble code

* 4750,5450: remove ref impls for now

* appease our overlord, walidator

* Apply suggestions from code review

Co-authored-by: Andrei Maiboroda <[email protected]>
Co-authored-by: Jochem Brouwer <[email protected]>

* reword type section intro

Co-authored-by: Paweł Bylica <[email protected]>

* apply feedback from review

Co-authored-by: Paweł Bylica <[email protected]>

* 4750: do not cleanup stack after jumpf or retf

* remove rationale for stack cleanup

* Apply suggestions from code review

Co-authored-by: Paweł Bylica <[email protected]>

* 4750: remove jumpf for later definition

* fix stale comment

Co-authored-by: Danno Ferrin <[email protected]>

* fix a couple typos and improve clarity

* appease link checker

* note terminating instruction requirement from 5450

* cap max_stack_height at 1023

* add padding to table

* fix padding

Co-authored-by: Andrei Maiboroda <[email protected]>

* revert terminating instructions change to 3670

* fix rearranged sections

Co-authored-by: Andrei Maiboroda <[email protected]>

* Apply suggestions from code review

Co-authored-by: Paweł Bylica <[email protected]>

Co-authored-by: Andrei Maiboroda <[email protected]>
Co-authored-by: Jochem Brouwer <[email protected]>
Co-authored-by: Paweł Bylica <[email protected]>
Co-authored-by: Danno Ferrin <[email protected]>

* Fixes bug when replacing asset on sample implementation of 5773 (#6202)

* Fixes bug when replacing asset on sample implementation of 5773.

* Rename the smart contract in specification

The smart contract specification was renamed to be identic to the name
of the proposal. This has been done so that the assets changes can be
merged.

Co-authored-by: Jan Turk <[email protected]>

* 4750,5450: Specify stack overflow check only in CALLF (#6205)

* 4750,5450: Specify stack overflow check only in CALLF

* Apply suggestions from code review

Co-authored-by: lightclient <[email protected]>

Co-authored-by: lightclient <[email protected]>

* Add EIP-6206: EOF - JUMPF instruction (#6206)

* add jumpf eip

* add eip number and discussion link

* Fix markdownlint errors

* Last markdownlint error

* Fix invalid link

* Formatting stuff

Co-authored-by: Pandapip1 <[email protected]>

* Update EIP-5115: Updates to interface based on community feedback (#6207)

* Update EIP-5115: Changes based from community feedback

* Update EIP-5115: Changes in interface and definitions

* Update EIP-5115: Linting fixes

* Update EIP-5115: Minor correction on interface (#6208)

* Update eip-4337.md : typo desribed -> described (#6169)

* clarify that initcode which fails validation still pays 3860 initcode cost (#6210)

* remove pc instruction from eof (#6209)

* Add EIP-6170: Cross-Chain Messaging Interface (#6172)

* cross-chain messaging interface

* fix: markdown linter fix

* chore: updating EIP name

* Apply suggestions from code review

* chore: changing specification to natspec interface

* Update eip-6170.md

Co-authored-by: Matt Stam <[email protected]>

* Update eip-6170.md

* Update eip-6170.md

* chore: remove events to discuss further

* Move file to correct folder

Co-authored-by: Pandapip1 <[email protected]>
Co-authored-by: Matt Stam <[email protected]>

* Ignore JetBrains project files (#6211)

* Update EIP-5568: Move to review (#6177)

* Update EIP-5606: Move to Last Call (#6151)

* Update EIP-5606: Moving to Last Call

* Update EIP-5606: Added Last Call Deadline

* Update EIP-5606: Fixed a typo

* Update EIPS/eip-5606.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIP-5219: Move to review (#6180)

* Update EIP-5219: Move to review

* Merge master into eip-5219-review (#6183)

* Update EIP-5507: Add Rationale stub (#6181)

* Update EIP-5219: Fix small typo (#6182)

* Update EIP-5380: Second Revision (#6214)

Co-authored-by: Mikhail Kalinin <[email protected]>
Co-authored-by: Danny Ryan <[email protected]>
Co-authored-by: lightclient <[email protected]>
Co-authored-by: Andrei Maiboroda <[email protected]>
Co-authored-by: Jochem Brouwer <[email protected]>
Co-authored-by: Paweł Bylica <[email protected]>
Co-authored-by: Danno Ferrin <[email protected]>
Co-authored-by: Steven Pineda <[email protected]>
Co-authored-by: Jan Turk <[email protected]>
Co-authored-by: Anton Buenavista <[email protected]>
Co-authored-by: taek <[email protected]>
Co-authored-by: Sujith Somraaj <[email protected]>
Co-authored-by: Matt Stam <[email protected]>
Co-authored-by: Paweł Bylica <[email protected]>
Co-authored-by: Gaurang Torvekar <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
@github-actions github-actions bot added c-new Creates a brand new proposal c-update Modifies an existing proposal s-draft This EIP is a Draft t-core t-interface labels Dec 25, 2022
@Pandapip1
Copy link
Member Author

For some reason GitHub isn't showing this branch. I'm going to create a new PR.

@Pandapip1 Pandapip1 closed this Dec 25, 2022
@Pandapip1 Pandapip1 deleted the eip-5380-review branch December 25, 2022 23:31
@Pandapip1 Pandapip1 mentioned this pull request Dec 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-new Creates a brand new proposal c-status Changes a proposal's status c-update Modifies an existing proposal s-draft This EIP is a Draft s-review This EIP is in Review t-core t-erc t-interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pandapip1 @eth-bot @SamWilsn