-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: P2P Escrowed Governance Incentives #6506
Conversation
All reviewers have approved. Auto merging... |
EIP editors, is this numbered 6504 due to closed PR #6504? |
That was me. I closed that PR in order to make more local edits and clean up the change history. Sorry if that screwed up the process. |
Generally EIPs/ERCs are numbered after the first PR #, but will need to wait and see what the EIP editors assign. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6506 is fine
EIPS/eip-6506.md
Outdated
|
||
2. The lack of an existing standard means that parties are relying entirely on trust in one-another to obey. Bob has to trust Alice to pay out and Alice has to trust Bob to vote. Even if the two of them were to use an escrow contract, it may have flaws like relying on a trusted third-party, or simply that it is outside the technical reach of both parties. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EIPS/eip-6506.md
Outdated
|
||
The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119 and RFC 8174. | ||
|
||
The key words "BRIBE" and "INCENTIVE" are to be interpreted as the transfer of a digital-asset(s) from user A to user B in exchange for an assurance that user B will vote in a specific-direction, on a specific proposal, for a specified-DAO. If user B does not honor the arrange, the digital-asset(s) will be returned to user A. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key words "BRIBE" and "INCENTIVE" are to be interpreted as the transfer of a digital-asset(s) from user A to user B in exchange for an assurance that user B will vote in a specific-direction, on a specific proposal, for a specified-DAO. If user B does not honor the arrange, the digital-asset(s) will be returned to user A. | |
The key words "BRIBE" and "INCENTIVE" are to be interpreted as the transfer of a digital-asset(s) from user A to user B in exchange for an assurance that user B will vote in a specific-direction, on a specific proposal, for a specified-DAO. If user B does not honor the arrangement, the digital-asset(s) will be returned to user A. |
EIPS/eip-6506.md
Outdated
type: bytes calldata | ||
``` | ||
|
||
#### claimIncentive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use backticks for any code in headings, for example:
#### `claimIncentive`
EIPS/eip-6506.md
Outdated
|
||
## Security Considerations | ||
|
||
EIP-TODO is a standard intended to work with existing governance systems. Any potential issue with existing governance may represent a potential attack on this as well. This includes voting-weight manipulation, vote forgery, verification discrepancies etc. All systems in which this EIP is integrated with should be properly audited for maximum security, as any issues may result in improper distribution of these governance incentives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EIP-TODO is a standard intended to work with existing governance systems. Any potential issue with existing governance may represent a potential attack on this as well. This includes voting-weight manipulation, vote forgery, verification discrepancies etc. All systems in which this EIP is integrated with should be properly audited for maximum security, as any issues may result in improper distribution of these governance incentives. | |
This proposal is a standard intended to work with existing governance systems. Any potential issue with existing governance may represent a potential attack on this as well. This includes voting-weight manipulation, vote forgery, verification discrepancies etc. All systems in which this EIP is integrated with should be properly audited for maximum security, as any issues may result in improper distribution of these governance incentives. |
I have made the requested revisions alongside various syntatic changes made during development. An official reference implementation can be found at the following repo |
The commit 256fbd8 (as a parent of b848eb0) contains errors. |
* Add EIP: P2P Escrowed Governance Incentives * renamed file for appropriate number * updated with requested changes and full implementation spec * attempted fix of walidator errors * markdown linter fix * Apply suggestions from code review --------- Co-authored-by: Sam Wilson <[email protected]>
* Add EIP: P2P Escrowed Governance Incentives * renamed file for appropriate number * updated with requested changes and full implementation spec * attempted fix of walidator errors * markdown linter fix * Apply suggestions from code review --------- Co-authored-by: Sam Wilson <[email protected]>
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: