Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Add @abcoathup as ERC/Meta/Informational editor #6575

Closed
wants to merge 1 commit into from

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Feb 24, 2023

@eth-bot
Copy link
Collaborator

eth-bot commented Feb 24, 2023

File config/eip-editors.yml

Requires 3 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Feb 24, 2023
@SamWilsn
Copy link
Contributor

SamWilsn commented Mar 8, 2023

If @abcoathup's intent is to only assign EIP numbers, I would rather we push for automation.

Instead if @abcoathup wants to participate as a full editor, I'd recommend a trial period like we did for @xinbenlv.

@Pandapip1
Copy link
Member Author

@abcoathup would you be interested in becoming a trial editor?

@abcoathup
Copy link
Contributor

abcoathup commented Mar 9, 2023

@SamWilsn & @Pandapip1 🙏

If @abcoathup's intent is to only assign EIP numbers, I would rather we push for automation.

I'd prefer number issuing be automated too 😄 and that authors could get an EIP/ERC PR merged with minimal intervention. Then EIP/ERC editors could focus on using their domain knowledge to best improve draft EIP/ERCs.

I check the repo each week day (along with Eth Magician discussions), but realistically could give about 30 minutes a day to editing. Enough to help with quick wins to get PRs into shape for merging, e.g. number assignment, guidance on how to comply with the automation, typos etc, but not enough to get into too many weeds.

I wouldn't be able to attend any meetings as the timing doesn't work with my timezone (Melbourne)

Instead if @abcoathup wants to participate as a full editor, I'd recommend a trial period like we did for @xinbenlv.

If what I can offer is suitable, then happy to do a trial period.
Also if not suitable, no offence taken, I will be here still asking about EIP numbers.

@Pandapip1
Copy link
Member Author

Great! CC @SamWilsn @axic @lightclient @gcolvin

@xinbenlv
Copy link
Contributor

What's our plan for bot-assigning numbers?

@Pandapip1
Copy link
Member Author

What's our plan for bot-assigning numbers?

WIP, but a prototype has been made. I'm waiting on a full review from sam.

@SamWilsn
Copy link
Contributor

@abcoathup we'd be happy to have you at that level of commitment! I guess our informal process is to have you start reviewing/commenting on PRs in the same way as an editor, and after some time we can add you to the editors list.

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 16, 2023
@abcoathup
Copy link
Contributor

I've mostly assigned EIP/ERC numbers and some minor suggestions to draft EIP/ERCs. Happy to stay in this role.

@github-actions github-actions bot removed the w-stale Waiting on activity label Aug 18, 2023
@Pandapip1
Copy link
Member Author

Bump.

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Sep 3, 2023
@Pandapip1
Copy link
Member Author

Bump.

CC @SamWilsn

@abcoathup
Copy link
Contributor

I'm still happy assigning EIP/ERC numbers (assigned 9 of the last 13 sequential numbers).
Meetings are generally whilst I am asleep so I won't be attending.

@SamWilsn
Copy link
Contributor

Closing because of #6575 (comment). If you'd like to apply for editorship, @abcoathup, please open a new pull request (or get someone to re-open this one.)

@SamWilsn SamWilsn closed this Sep 13, 2023
@Pandapip1 Pandapip1 deleted the Pandapip1-patch-3 branch September 13, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants