-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: L2 Token List #6734
Add EIP: L2 Token List #6734
Conversation
File
|
@eth-bot rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the CI errors.
@SamWilsn only the NIST CVE link is giving problems. Can the Editors add the NIST NVD to the list of allowed references? |
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
@SamWilsn addressed your requests. The last open item is to add NIST to the list of allowed URLs. Is there anything I need to in terms of the process to request that? |
You'll need to open a pull request to EIP-1 to add it, following the guidelines in EIP-5757. I'll add it to tomorrow's EIPIP call to discuss. |
#7542 <- pull request to allow links to NIST CVEs |
EIPS/eip-6734.md
Outdated
|
||
## Security Considerations | ||
|
||
There are no additional security requirements apart from the warnings that URIs utilized in implementations of this standard might be direct to malicious resources such as websites, and that implementers should ensure that data utilized for a canonical token list is secure and correct. Since this standard is focused on a data schema and its data properties there are no additional security considerations from for example homoglyph attacks (see [CVE-2021-42574](https://nvd.nist.gov/vuln/detail/CVE-2021-42574)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no additional security requirements apart from the warnings that URIs utilized in implementations of this standard might be direct to malicious resources such as websites, and that implementers should ensure that data utilized for a canonical token list is secure and correct. Since this standard is focused on a data schema and its data properties there are no additional security considerations from for example homoglyph attacks (see [CVE-2021-42574](https://nvd.nist.gov/vuln/detail/CVE-2021-42574)). | |
There are no additional security requirements apart from the warnings that URIs utilized in implementations of this standard might be direct to malicious resources such as websites, and that implementers should ensure that data utilized for a canonical token list is secure and correct. Since this standard is focused on a data schema and its data properties there are no additional security considerations from for example homoglyph attacks (see [CVE-2021-42574 (2021-10-25T12:38:28)](https://nvd.nist.gov/vuln/detail/CVE-2021-42574)). |
Until eipw
is updated to support links to CVEs, all pull requests to this EIP will require a manual merge. Sorry about the inconvenience!
The commit 4982606 (as a parent of a3763bc) contains errors. |
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: