Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Registry for royalties payment for NFTs #6786

Merged
merged 6 commits into from
May 20, 2023
Merged

Add EIP: Registry for royalties payment for NFTs #6786

merged 6 commits into from
May 20, 2023

Conversation

Bogdan-ChainImpulse
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added s-draft This EIP is a Draft t-erc labels Mar 27, 2023
@eth-bot eth-bot changed the title Add ERC-5666: Add Royalty Debt Registry Add EIP: ERC-5666 - Registry for royalties payment for NFTs Mar 27, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 27, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Mar 27, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Mar 27, 2023
@github-actions github-actions bot added the c-new Creates a brand new proposal label Mar 27, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Mar 27, 2023
@eth-bot eth-bot changed the title Add EIP: ERC-5666 - Registry for royalties payment for NFTs Add EIP: Registry for royalties payment for NFTs Mar 27, 2023
abcoathup
abcoathup reviewed Mar 28, 2023
View reviewed changes
EIPS/eip-5666.md Outdated
@@ -0,0 +1,105 @@
---
eip: 5666
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: 5666
eip: 6786

Assigning ERC number using PR number.

@poojaranjan poojaranjan mentioned this pull request Apr 18, 2023
Closed
23 tasks
@poojaranjan poojaranjan mentioned this pull request May 2, 2023
Closed
20 tasks
@OT-kraftchain OT-kraftchain mentioned this pull request May 5, 2023
Closed
19 tasks
SamWilsn
SamWilsn reviewed May 16, 2023
View reviewed changes
EIPS/eip-6786.md Outdated
event RoyaltiesPaid(address indexed tokenAddress, uint256 indexed tokenId, uint256 amount);

/// @notice sends msg.value to the creator of a NFT
/// @dev Throws if there are no on-chain informations about the creator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps reverts is a better term?

Suggested change
/// @dev Throws if there are no on-chain informations about the creator
/// @dev Reverts if there are no on-chain informations about the creator

EIPS/eip-6786.md Outdated

All functions defined as view MAY be implemented as pure or view

Function payRoyalties MAY be implemented as public or external
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Function payRoyalties MAY be implemented as public or external
Function `payRoyalties` MAY be implemented as public or external

EIPS/eip-6786.md Outdated

## Rationale

With a lot of places made for trading NFTs dropping down the royalty payment or having a centralised approach, we want to provide a way for anyone to pay royalties to the creators.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph belongs in the motivation section because it is justifying the EIP as a whole, and not describing a specific technical choice made within the EIP.

assets/eip-6786/LICENSE Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to include CC0 as it's included in the root of the repository.

assets/eip-6786/README.md Outdated

# ERC6786 Royalty Debt Registry

[![License: CC0-1.0](https://img.shields.io/badge/License-CC0-yellow.svg)](https://creativecommons.org/publicdomain/zero/1.0/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove any external links.

Suggested change
[![License: CC0-1.0](https://img.shields.io/badge/License-CC0-yellow.svg)](https://creativecommons.org/publicdomain/zero/1.0/)

assets/eip-6786/abi/ERC6786.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ABI files aren't strictly necessary to understand the reference implementation, so please remove them.

assets/eip-6786/hardhat.config.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove any build system configuration files.

assets/eip-6786/scripts/deploy_contracts.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical to understand the reference implementation, please remove.

@github-actions
Copy link

The commit 2a0064f (as a parent of c8cc3fb) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 17, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 17, 2023
SamWilsn
SamWilsn reviewed May 20, 2023
View reviewed changes
assets/eip-6786/contracts/ERC6786.sol Outdated Show resolved Hide resolved
assets/eip-6786/contracts/IERC6786.sol Outdated Show resolved Hide resolved
assets/eip-6786/contracts/token/ERC721Royalty.sol Outdated Show resolved Hide resolved
@eth-bot eth-bot enabled auto-merge (squash) May 20, 2023 05:33
eth-bot
eth-bot approved these changes May 20, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 749bb69 into ethereum:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bogdan-ChainImpulse @eth-bot @abcoathup @SamWilsn