Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Order Book DEX with Two Phase Withdrawal #6787

Merged
merged 25 commits into from
May 24, 2023

Conversation

qizheng09
Copy link
Contributor

@qizheng09 qizheng09 commented Mar 27, 2023

The Order Book DEX Standard is a proposed set of interface specifications that define a decentralized exchange protocol for trading assets using order books. This standard provides a set of functions that allow users to deposit, withdraw, and trade assets on a decentralized exchange. Additionally, it innovatively proposes a two-phase withdrawal scheme to ensure the asset security of both users and the exchange, addressing users' trust issues with the exchange.

@qizheng09 qizheng09 requested a review from eth-bot as a code owner March 27, 2023 14:13
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Mar 27, 2023
@qizheng09 qizheng09 changed the title ERC: A standard order book-based DEX ERC: A order book DEX standard with two-phase withdrawal Mar 27, 2023
@eth-bot eth-bot changed the title ERC: A order book DEX standard with two-phase withdrawal Add EIP: Order Book DEX Standard Mar 27, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 27, 2023

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Mar 27, 2023
@qizheng09 qizheng09 changed the title Add EIP: Order Book DEX Standard Add EIP: Order Book DEX with two-phase withdrawal Mar 27, 2023
@qizheng09 qizheng09 changed the title Add EIP: Order Book DEX with two-phase withdrawal Add EIP: Order Book DEX with Two Phase Withdrawal Mar 27, 2023
@eth-bot eth-bot changed the title Add EIP: Order Book DEX with Two Phase Withdrawal Add EIP: Order Book DEX with Two Phase Withdrawal Mar 27, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Mar 27, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Mar 27, 2023
@qizheng09
Copy link
Contributor Author

Blockchain-driven finance requires us to continuously iterate protocols and solidify good financial protocols. The 1:1 reserve ratio and two-phase withdrawal protocol can ensure the security of assets for both users and project parties. It is a good solution for order book-based DEX built on Layer 2 technology.

@Pandapip1
Copy link
Member

@eth-bot rerun

EIPS/eip-6787.md Outdated Show resolved Hide resolved
EIPS/eip-6787.md Outdated Show resolved Hide resolved
EIPS/eip-6787.md Outdated Show resolved Hide resolved
EIPS/eip-6787.md Show resolved Hide resolved
EIPS/eip-6787.md Outdated Show resolved Hide resolved
EIPS/eip-6787.md Outdated Show resolved Hide resolved
EIPS/eip-6787.md Outdated Show resolved Hide resolved
EIPS/eip-6787.md Outdated Show resolved Hide resolved
EIPS/eip-6787.md Outdated Show resolved Hide resolved
@github-actions
Copy link

The commit d512737 (as a parent of 520f7dc) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 4, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

As more of a suggestion than a requirement, I would add a two new headings under Specification: ### Interface and ### Settling. Move all the functions (eg. deposit, withdraw, etc) under ### Interface, and move the settling requirements under ### Settling.

The example should be removed for now, and eventually re-added to your reference implementation if you add one.

EIPS/eip-6787.md Outdated Show resolved Hide resolved
EIPS/eip-6787.md Outdated Show resolved Hide resolved
EIPS/eip-6787.md Outdated Show resolved Hide resolved
@qizheng09
Copy link
Contributor Author

qizheng09 commented May 6, 2023

@SamWilsn

Hi Sam! Thank for your reply! I remove the settle function now and will add it to reference implementation in future!

@SniperUsopp
Copy link

This is a great idea and I hope this proposal will become a standard agreement soon. This has significant implications for the security of users' assets.

EIPS/eip-6787.md Outdated Show resolved Hide resolved
@eth-bot eth-bot enabled auto-merge (squash) May 24, 2023 05:27
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ef5fe54 into ethereum:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants