-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Order Book DEX with Two Phase Withdrawal #6787
Conversation
✅ All reviewers have approved. |
Blockchain-driven finance requires us to continuously iterate protocols and solidify good financial protocols. The 1:1 reserve ratio and two-phase withdrawal protocol can ensure the security of assets for both users and project parties. It is a good solution for order book-based DEX built on Layer 2 technology. |
@eth-bot rerun |
The commit d512737 (as a parent of 520f7dc) contains errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
As more of a suggestion than a requirement, I would add a two new headings under Specification: ### Interface
and ### Settling
. Move all the functions (eg. deposit
, withdraw
, etc) under ### Interface
, and move the settling requirements under ### Settling
.
The example should be removed for now, and eventually re-added to your reference implementation if you add one.
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Hi Sam! Thank for your reply! I remove the |
This is a great idea and I hope this proposal will become a standard agreement soon. This has significant implications for the security of users' assets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
The Order Book DEX Standard is a proposed set of interface specifications that define a decentralized exchange protocol for trading assets using order books. This standard provides a set of functions that allow users to deposit, withdraw, and trade assets on a decentralized exchange. Additionally, it innovatively proposes a two-phase withdrawal scheme to ensure the asset security of both users and the exchange, addressing users' trust issues with the exchange.