Add EIP: Non-Fungible Key Bound Token #6809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
|
✅ All reviewers have approved. |
eth-bot
changed the title
eth-bot
added
e-consensus
eth-bot
changed the title
Pandapip1
previously requested changes
Apr 1, 2023
EIPS/eip-6809.md
Outdated
| requires: 721 | ||
| --- | ||
|
|
||
| A standard interface for Non-Fungible Key Bound Tokens, also known as a Non-Fungible **KBT**[^1]. |
There was a problem hiding this comment.
@SamWilsn - why was this not flagged by EIPw?
Suggested change
| A standard interface for Non-Fungible Key Bound Tokens, also known as a Non-Fungible **KBT**[^1]. |
There was a problem hiding this comment.
Hi @Pandapip1, we can remove the 'standard' keyword if that's the issue. Can you guide us on how to proceed with the Source URLs in the footnotes?
There was a problem hiding this comment.
No, it's that there's text outside of any section. There must not be text outside of any section.
There was a problem hiding this comment.
@SamWilsn - why was this not flagged by EIPw?
There's no lint for it 🤣
sgilflores3
previously approved these changes
Apr 1, 2023
* Updated the Specification section + replaced the png with and svg file + Fixed the assets issue with package-lock * Fixed the licence in the KBT contract --------- Co-authored-by: KBT Admin <[email protected]>
github-actions
bot
added
w-ci
23 tasks
SamWilsn
reviewed
Apr 18, 2023
EIPS/eip-6809.md
Outdated
|
|
||
| ## Motivation | ||
|
|
||
| TIn this fast-paced technologically advancing world, people learn and mature at different speeds. The goal of global adoption must take into consideration the target demographic is of all ages and backgrounds. Unfortunately for self-custodial assets, one of the greatest pros is also one of its greatest cons. The individual is solely responsible for their actions and adequately securing their assets. If a mistake is made leading to a loss of funds, no one is able to guarantee their return. |
There was a problem hiding this comment.
Suggested change
| TIn this fast-paced technologically advancing world, people learn and mature at different speeds. The goal of global adoption must take into consideration the target demographic is of all ages and backgrounds. Unfortunately for self-custodial assets, one of the greatest pros is also one of its greatest cons. The individual is solely responsible for their actions and adequately securing their assets. If a mistake is made leading to a loss of funds, no one is able to guarantee their return. | |
| In this fast-paced technologically advancing world, people learn and mature at different speeds. The goal of global adoption must take into consideration the target demographic is of all ages and backgrounds. Unfortunately for self-custodial assets, one of the greatest pros is also one of its greatest cons. The individual is solely responsible for their actions and adequately securing their assets. If a mistake is made leading to a loss of funds, no one is able to guarantee their return. |
* Rephrased the Reference Implementation. * Changed the heading in Specifications section * Linked the functions to the headings instead of the footnotes + removed unused footnotes * Security Considerations redirect - rationale section * Spell Check 1 + BIP / SLIP removal + the ERC check + Footnote removal & # Update * motivation topic bolding change * Motivation FTC Sentence + keyWallet fix + Footnote Reduction Variation 1 + Re-number * Added _ to some `keyWallet1` & `keyWallet2` + Footnote update * Motivation FTC section sentence Split * Rationale - Returns on Bools * Key Wallet Reduction + anyToken --------- Co-authored-by: KBT Admin <[email protected]> Co-authored-by: NickZCZ <[email protected]> Co-authored-by: MihaiORO <[email protected]>
|
The commit fa51558 (as a parent of 4746ed7) contains errors. |
20 tasks
SamWilsn
reviewed
May 2, 2023
Co-authored-by: Sam Wilson <[email protected]>
SamWilsn
approved these changes
May 2, 2023
NarcisCRO
approved these changes
May 2, 2023
eth-bot
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A standard interface for Non-Fungible Key Bound Tokens, also known as a Non-Fungible KBT
The Key Bound Token Standard is a new standard focused on self-custodial security. The users of the non-fungible version can benefit from its integrated decentralized anti-theft mechanism. By binding two additional wallets, this standard prevents attackers and scammers alike to use your asset, even if they gain control of your seed phrase or private key.