Add EIP: NFT Fusing Protocol #6927

saitama2009 · 2023-04-24T16:57:58Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

eth-bot · 2023-04-24T16:58:25Z

File `EIPS/eip-6927.md`

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

github-actions · 2023-05-04T00:35:32Z

The commit af6390e (as a parent of 5c69963) contains errors.
Please inspect the Run Summary for details.

SamWilsn · 2023-09-20T15:09:18Z

EIPS/eip-6927.md

+---
+eip: 6927
+title: NFT Fusing Protocol
+description: Fusing multiple NFTs into a new one.


Your description doesn't really add any new information that wasn't in the title. How about something like:

Suggested change

description: Fusing multiple NFTs into a new one.

description: An ERC-721 extension for merging multiple tokens into a combo and later separating them.

SamWilsn · 2023-09-20T15:11:28Z

EIPS/eip-6927.md

+type: Standards Track
+category: ERC
+created: 2023-04-23
+requires: 165, 721


You don't mention the use of ERC-165 in your Specification section. You can remove 721 from your requires header, or mention that smart contract conforming to this proposal need to implement ERC165.

SamWilsn · 2023-09-20T16:12:58Z

EIPS/eip-6927.md

+
+The keywords “MUST,” “MUST NOT,” “REQUIRED,” “SHALL,” “SHALL NOT,” “SHOULD,” “SHOULD NOT,” “RECOMMENDED,” “MAY,” and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.
+
+**Interface**


Suggested change

**Interface**

### Interface

SamWilsn · 2023-09-20T16:21:25Z

EIPS/eip-6927.md

+## Test Cases
+
+Test cases should be developed to cover the following scenarios:
+
+* Minting a valid combo with ERC-721 and/or ERC-1155 NFTs.
+* Dismantling a combo and returning locked NFTs to their owners.
+* Setting combo rules and ensuring compliance during the minting - - process.
+* Approving ERC-721 NFTs for use in combos.
+* Querying combo rules and ingredients.
+
+## Reference Implementation 
+
+An implementation of this EIP will be provided upon acceptance of the proposal.
+


Suggested change

## Test Cases

Test cases should be developed to cover the following scenarios:

* Minting a valid combo with ERC-721 and/or ERC-1155 NFTs.

* Dismantling a combo and returning locked NFTs to their owners.

* Setting combo rules and ensuring compliance during the minting - - process.

* Approving ERC-721 NFTs for use in combos.

* Querying combo rules and ingredients.

## Reference Implementation

An implementation of this EIP will be provided upon acceptance of the proposal.



These sections are optional, and if you use an HTML-style comment, the linter will make sure you come back to them before advancing statuses.

SamWilsn · 2023-09-20T16:23:31Z

EIPS/eip-6927.md

+type: Standards Track
+category: ERC
+created: 2023-04-23
+requires: 165, 721


Suggested change

requires: 165, 721

requires: 165, 721, 1155

Ingredient.amount doesn't make sense unless you explicitly mention ERC-1155.

SamWilsn · 2023-09-20T16:24:42Z

EIPS/eip-6927.md

+    /// @param maxReuseCount Maximum total reuse count of a token from the collection in
+    /// this combo collection (only applicable for ERC-721 and when lockTokens is false)
+    struct ComboFactor {
+        address collectionAddress;


You should mention somewhere what standards the collectionAddress is allowed to be. I'm guessing it's ERC-721 and ERC-1155 from your Rationale section?

SamWilsn · 2023-10-25T22:11:36Z

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

Add:eip-draft_nft_fusing_standar

0f962ad

saitama2009 requested a review from eth-bot as a code owner April 24, 2023 16:57

github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Apr 24, 2023

eth-bot changed the title ~~Add:eip-draft_nft_fusing_standar~~ Add EIP: NFT Fusing Standard Apr 24, 2023

eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 24, 2023

github-actions bot added the w-ci Waiting on CI to pass label Apr 24, 2023

Assign PR number and update content

77a84cb

eth-bot changed the title ~~Add EIP: NFT Fusing Standard~~ Add EIP: NFT Fusing Protocol Apr 25, 2023

github-actions bot removed the w-ci Waiting on CI to pass label Apr 25, 2023

Update content

41d40e5

github-actions bot added the w-ci Waiting on CI to pass label Apr 25, 2023

saitama2009 and others added 2 commits May 2, 2023 08:33

Merge branch 'master' into draft_nft_fusing_standard

3418937

Commit from EIP-Bot

6a6eab8

eth-bot changed the base branch from master to eipbot/6927 May 2, 2023 00:34

Merge branch 'eipbot/6927' into draft_nft_fusing_standard

238ca06

eth-bot changed the base branch from eipbot/6927 to master May 2, 2023 00:34

github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 2, 2023

update eip number

af6390e

rename

9f98ea2

github-actions bot removed the w-ci Waiting on CI to pass label May 4, 2023

SamWilsn reviewed Sep 20, 2023

View reviewed changes

SamWilsn closed this Oct 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP: NFT Fusing Protocol #6927

Add EIP: NFT Fusing Protocol #6927

saitama2009 commented Apr 24, 2023

eth-bot commented Apr 24, 2023 •

edited

Loading

github-actions bot commented May 4, 2023

SamWilsn Sep 20, 2023

SamWilsn Sep 20, 2023

SamWilsn Sep 20, 2023

SamWilsn Sep 20, 2023

SamWilsn Sep 20, 2023

SamWilsn Sep 20, 2023

SamWilsn commented Oct 25, 2023

	description: Fusing multiple NFTs into a new one.
	description: An ERC-721 extension for merging multiple tokens into a combo and later separating them.


		The keywords “MUST,” “MUST NOT,” “REQUIRED,” “SHALL,” “SHALL NOT,” “SHOULD,” “SHOULD NOT,” “RECOMMENDED,” “MAY,” and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.

		Interface

Add EIP: NFT Fusing Protocol #6927

Add EIP: NFT Fusing Protocol #6927

Conversation

saitama2009 commented Apr 24, 2023

eth-bot commented Apr 24, 2023 • edited Loading

File EIPS/eip-6927.md

github-actions bot commented May 4, 2023

SamWilsn Sep 20, 2023

Choose a reason for hiding this comment

SamWilsn Sep 20, 2023

Choose a reason for hiding this comment

SamWilsn Sep 20, 2023

Choose a reason for hiding this comment

SamWilsn Sep 20, 2023

Choose a reason for hiding this comment

SamWilsn Sep 20, 2023

Choose a reason for hiding this comment

SamWilsn Sep 20, 2023

Choose a reason for hiding this comment

SamWilsn commented Oct 25, 2023

eth-bot commented Apr 24, 2023 •

edited

Loading

File `EIPS/eip-6927.md`