Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-6672: Move to Last Call #6949

Merged
merged 35 commits into from
May 2, 2023
Merged

Update EIP-6672: Move to Last Call #6949

merged 35 commits into from
May 2, 2023

Conversation

Randyanto
Copy link
Contributor

Changes list

  • update implementation with Redeem and Cancel events
  • change status to Last Call

ArchieR7 and others added 30 commits February 22, 2023 15:46
@ArchieR7
docs(eip): add Redeemable NFTs
a93fa27
@ArchieR7
feat(specification): update Specification
aee69fa
@ArchieR7
Merge branch 'ethereum:master' into master
90d8c9d
@Randyanto
Add detailed explanation
a096660 
- add explanation
- change 9999 to 6672
@ArchieR7
Merge pull request #1 from redeemprotocol/add-explanation
611b5f3 
Add detailed explanation
@ArchieR7
docs(draft): rename
7fa034c
@ArchieR7
fix(draft): fix error[markdown-re-erc-dash]
462ade8
@ArchieR7
fix(draft): fix author and ref issues
581df4a
@ArchieR7
fix(draft): fix author and preamble-refs-description
f3158e4
@Randyanto
Change multiple-times to multiple-scenarios
47dbc48
@Randyanto
Merge pull request #2 from redeemprotocol/multiple-scenarios
a5caf51 
Change multiple-times to multiple-scenarios
@Randyanto
Add link to discussion
e9ab86b 
- add link to discussion 
- fix "ERP" typo
@Randyanto
Small fixes based on Editor feedback for EIP6672
920a033 
- explain what-is-redemption in Abstract
- mention one example use case in Motivation
- move some sentences from Rationale to Specification
Move reference implementation to assets folder
cbd4f98
EIP6672 - fix error found by WIP Walidator
f2f05e3
EIP6672 - fix error found by WIP Walidator
7984c49
EIP6672 - fix error found by WIP Walidator
0520556
EIP6672 - fix error found by HTMLProofer
c3be9bf
@ArchieR7
feat(erc6672): modify redemptions with EnumerableSet
237b019
@ArchieR7
feat(erc6672): remove unnessary functions
542612a
@ArchieR7
feat(erc6672): add supportsInterface()
979a057
@Randyanto
feat(erc6672): update security considerations
3094aee
@Randyanto
feat(erc6672): fix error found by WIP Walidator
566e33c
@Randyanto
feat(erc6672): add character I in the interface contract code for con…
ba651ff 
…sistency
@Randyanto
feat(erc6672): remove reference to stagnant EIP
7ff9cd1
@ArchieR7
Merge branch 'ethereum:master' into master
71c87f0
@ArchieR7
feat(erc6672): add ERC-165 identifier for ERC-6672
ec720d6
@Randyanto
feat(erc6672): change status to Review, remove existing-standards phr…
fe1a776 
…ase from motivation
@Randyanto
Merge pull request #3 from redeemprotocol/feature/move-to-review
11ca7f5 
feat(erc6672): remove reference to stagnant EIP
@ArchieR7
Merge branch 'ethereum:master' into master
0edf7ff
@Randyanto Randyanto requested a review from eth-bot as a code owner April 28, 2023 06:56
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Apr 28, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 28, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Apr 28, 2023
@Randyanto Randyanto mentioned this pull request May 2, 2023
Closed
20 tasks
SamWilsn
SamWilsn approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A friendly reminder than once a proposal goes into the Final status, it can no longer be edited, so please ensure that you have given your proposal an in-depth review before opening that pull request.

@eth-bot eth-bot enabled auto-merge (squash) May 2, 2023 15:26
eth-bot
eth-bot approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 7405605 into ethereum:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Randyanto @eth-bot @SamWilsn @ArchieR7