-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Perpetually Valid Signed Voluntary Exits #7044
Conversation
✅ All reviewers have approved. |
09b3af7
to
788b596
Compare
EIPS/eip-7044.md
Outdated
|
||
### Consensus Layer | ||
|
||
The mechanics of the specification can be found in the [Consensus Layer specs](https://github.com/ethereum/consensus-specs/pull/3288). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will need to refer to a blob
commit of the relevant content rather than a PR (once PR is merged i guess)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dapplion we are modifying the regex to support the compare
diffs in drafts instead of PRs as the diffs are static: so basically this for your PR: https://github.com/ethereum/consensus-specs/compare/1c35eb1c3303fe1e0b101323106d766d8f848cd6~3...1c35eb1c3303fe1e0b101323106d766d8f848cd6
which is this link
I suspect this EIP is trying to address a common problem faced by staking pool operators: How can their customers be sure that the operator won't keep the created validators active forever (this allows the operator to profit from transaction fees and MEV)? To solve this problem in a more comprehensive way, it may be beneficial to also introduce a new type of exit message that identifies the exited validator by their public key. This is an improvement because it will allow the staking pool to share the signed exit message with the staker before the staker has committed to fund the created validator. This is not easy to do otherwise, because the final validator index is now known until the deposit has been processed by the beacon chain. I've written more about this here: One possible work-around with significant downsides is to require the operator to sign a very wide range of exit messages that target all possible validator indices. |
@eth-bot rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some clean-ups in language and links to get this thing mergeddd
EIPS/eip-7044.md
Outdated
|
||
### Consensus Layer | ||
|
||
The mechanics of the specification can be found in the [Consensus Layer specs](https://github.com/ethereum/consensus-specs/commit/14212958d3605c5dd4f8ab617f157328f53ce559). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specification changes are built into the Consensus Specs Deneb upgrade.
The specific makes one change to the state transition function:
- Modify
process_voluntary_exit
](https://github.com/ethereum/consensus-specs/blob/75971a8c218b1d76d605dd8b88a08d39c42de221/specs/deneb/beacon-chain.md#modified-process_voluntary_exit) to compute the signing domain and root fixed onCAPELLA_FORK_VERSION
.
Additionally, the voluntary_exit
gossip conditions are implicitly modified to support this change.
Co-authored-by: Andrew B Coathup <[email protected]>
1c11651
to
7ac7f0c
Compare
The commit 1c11651 (as a parent of 6500963) contains errors. |
rebased via UI to check the link validation, is now successful @dapplion |
Co-authored-by: Danny Ryan <[email protected]>
Co-authored-by: Danny Ryan <[email protected]>
Co-authored-by: Danny Ryan <[email protected]>
Co-authored-by: Danny Ryan <[email protected]>
Co-authored-by: Danny Ryan <[email protected]>
Co-authored-by: Danny Ryan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
todo: