Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1: Semi-stagnation of last call EIPs #7346

Closed
wants to merge 2 commits into from

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Jul 17, 2023

Fixes #7328

Note that the stagnant bot does NOT touch Last call EIPs, which is technically not in line with the current EIP-1.

I am working on a new and improved stagnant bot.

@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Jul 17, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 17, 2023

File EIPS/eip-1.md

Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jul 17, 2023
@Pandapip1 Pandapip1 marked this pull request as ready for review July 17, 2023 15:07
@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner July 17, 2023 15:07
lightclient
lightclient previously approved these changes Jul 24, 2023
@@ -79,15 +79,15 @@ The following is the standardization process for all EIPs in all tracks:

**Review** - An EIP Author marks an EIP as ready for and requesting Peer Review.

**Last Call** - This is the final review window for an EIP before moving to `Final`. An EIP editor will assign `Last Call` status and set a review end date (`last-call-deadline`), typically 14 days later.
**Last Call** - This is the final review window for an EIP before moving to `Final`. An EIP editor will assign `Last Call` status and set a review end date (`last-call-deadline`), typically 14 days later. If 6 months pass after the `last-call-deadline`, it is moved back into `Review`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move it to Stagnant directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last call should imply some degree of community participation. If you want, this time can be reduced down to e.g. one month. But -1 to moving directly to Stagnant.

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 15, 2023
@github-actions github-actions bot removed the w-stale Waiting on activity label Jan 20, 2024
Copy link

github-actions bot commented Feb 5, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 5, 2024
Copy link

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Last Call EIPs into Review 6 months after the last-call-deadline passes
5 participants