Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7066: Move to Review #7353

Merged
merged 60 commits into from
Jul 29, 2023
Merged

Update EIP-7066: Move to Review #7353

merged 60 commits into from
Jul 29, 2023

Conversation

streamnft-tech
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal s-review This EIP is in Review t-erc labels Jul 18, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jul 18, 2023 •
edited
Loading

File EIPS/eip-7066.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot changed the title Erc721 lockable Add EIP: Lockable Extension for ERC-721 Jul 18, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jul 18, 2023
@github-actions github-actions bot added c-status Changes a proposal's status and removed c-new Creates a brand new proposal labels Jul 18, 2023
@eth-bot eth-bot changed the title Add EIP: Lockable Extension for ERC-721 Update EIP-7066: Move to Review Jul 18, 2023
@streamnft-tech
Copy link
Contributor Author

@eth-bot rerun

@piyush-chittara piyush-chittara mentioned this pull request Jul 25, 2023
Closed
21 tasks
@lightclient lightclient merged commit ca25e84 into ethereum:master Jul 29, 2023
10 checks passed
This was referenced Aug 31, 2023
Merged
Merged
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
@SamWilsn @RaphaelHardFork
Update EIP-7066: Move to Review (ethereum#7353)
ae91a34 
* erc721lockable init

* update discussion

* update license

* update readme

* add eip header

* update title

* update readme

* update readme

* update readme

* update readme

* update eip number

* update eip number

* update eip number

* update eip number

* update eip number

* update readme

* update readme

* update readme

* update readme

* error codes

* added interface to specification

* lint fixe

* transfer with lock/approve

* rename

* readme update

* optimize lock/unlock

* readme with new functions

* readme update

* error codes

* discussion link

* tokenId

* remove redundancy

* updates test

* updates doc

* review fixes

* overrides and interface correction

* add locker to transferAndLock

* remove locker

* license

* doc update

* doc update

* doc update

* author updates

* EIP7066 review

---------

Co-authored-by: piyush.chittara <[email protected]>
Co-authored-by: Piyush <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
@SamWilsn @just-a-node
Update EIP-7066: Move to Review (ethereum#7353)
8cabda1 
* erc721lockable init

* update discussion

* update license

* update readme

* add eip header

* update title

* update readme

* update readme

* update readme

* update readme

* update eip number

* update eip number

* update eip number

* update eip number

* update eip number

* update readme

* update readme

* update readme

* update readme

* error codes

* added interface to specification

* lint fixe

* transfer with lock/approve

* rename

* readme update

* optimize lock/unlock

* readme with new functions

* readme update

* error codes

* discussion link

* tokenId

* remove redundancy

* updates test

* updates doc

* review fixes

* overrides and interface correction

* add locker to transferAndLock

* remove locker

* license

* doc update

* doc update

* doc update

* author updates

* EIP7066 review

---------

Co-authored-by: piyush.chittara <[email protected]>
Co-authored-by: Piyush <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@SamWilsn @GAEAlimited
Update EIP-7066: Move to Review (ethereum#7353)
bb0b13e 
* erc721lockable init

* update discussion

* update license

* update readme

* add eip header

* update title

* update readme

* update readme

* update readme

* update readme

* update eip number

* update eip number

* update eip number

* update eip number

* update eip number

* update readme

* update readme

* update readme

* update readme

* error codes

* added interface to specification

* lint fixe

* transfer with lock/approve

* rename

* readme update

* optimize lock/unlock

* readme with new functions

* readme update

* error codes

* discussion link

* tokenId

* remove redundancy

* updates test

* updates doc

* review fixes

* overrides and interface correction

* add locker to transferAndLock

* remove locker

* license

* doc update

* doc update

* doc update

* author updates

* EIP7066 review

---------

Co-authored-by: piyush.chittara <[email protected]>
Co-authored-by: Piyush <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-consensus Waiting on editor consensus e-review Waiting on editor to review s-review This EIP is in Review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@streamnft-tech @eth-bot @lightclient @SamWilsn