Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-4626: replace old repo link #394

Closed
wants to merge 1 commit into from
Closed

Update ERC-4626: replace old repo link #394

wants to merge 1 commit into from

Conversation

Confucian-e
Copy link

Old link is invalid now because author changed file path. I replace that with correct url.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Apr 19, 2024 •
edited
Loading

File ERCS/erc-4626.md

Requires 1 more reviewers from @alcueca, @fubuloubu, @JetJadeja, @Joeysantoro, @transmissions11
Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title fix: replace old repo link Update ERC-4626: replace old repo link Apr 19, 2024
@github-actions GitHub Actions
Copy link

The commit ba3871d (as a parent of 7eacbbb) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Apr 19, 2024
@Confucian-e
Copy link
Author

@axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv
Could you check it out? Opened for a long time.

@poojaranjan poojaranjan mentioned this pull request May 22, 2024
Closed
14 tasks
@SamWilsn
Copy link
Collaborator

As discussed on EIPIP (ethcatherders/EIPIP#336), we prefer not updating Final proposals.

@SamWilsn SamWilsn closed this May 22, 2024
@fubuloubu
Copy link
Contributor

As discussed on EIPIP (ethcatherders/EIPIP#336), we prefer not updating Final proposals.

Updating a link hardly seems like a substantive change

@Confucian-e
Copy link
Author

As discussed on EIPIP (ethcatherders/EIPIP#336), we prefer not updating Final proposals.

Updating a link hardly seems like a substantive change

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@eip-review-bot eip-review-bot Awaiting requested review from eip-review-bot eip-review-bot is a code owner

Assignees
No one assigned
Labels
c-update e-consensus s-final t-erc w-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Confucian-e @eip-review-bot @SamWilsn @fubuloubu