Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-2612: ERC-2612 fix typo #57

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Joeysantoro
Copy link
Contributor

The mapping field is called allowance in EIP-20 not approval. This was likely a confusion with the event Approval

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 27, 2023

File ERCS/erc-2612.md

Requires 1 more reviewers from @MrChico
Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @Pandapip1, @SamWilsn

@eip-review-bot eip-review-bot changed the title ERC-2612 fix typo Update ERC-2612: ERC-2612 fix typo Oct 27, 2023
@github-actions
Copy link

The commit c8d7806 (as a parent of 4d763de) contains errors.
Please inspect the Run Summary for details.

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@SamWilsn SamWilsn merged commit f09e025 into ethereum:master Nov 15, 2023
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants