-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc standardization #1039
Doc standardization #1039
Conversation
Thank for this. I mostly care for consistency but will voice some personal bikesheding nonetheless 😂
|
Can I go forward with making all of those requested changes now? & For #10, are you saying to go with the full spelling "Ethereum 2.0" + em-dash in titles, like: Ethereum 2.0 Networking Spec — RPC Interface Thank you |
My suggestion would be something like "Ethereum 2.0 networking spec—RPC interface". No spaces between em-dash, avoid upper case except first word. Then again this is just my personal preference—mostly care for consistency. |
Value can be either:
👍 |
@JSON Thank you so much for making this! 👍 Personal preference here:
|
#2 = Done. Since it's the first mention, I agree a full spell out + (Serenity) is optimal. All that remains is a decision either way on ie/eg (this PR currently makes them all i.e./e.g. no comma) and a decision regarding title stylization (this PR currently leaves them as is). If no one wants to be declarative rn, this PR is ready to be merged as is, and I can do another scan for discrepancies in June for the Phase 0 spec freeze. Lmk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say we merge as is
Merged! Merging this quickly before merge conflicts make it impossible to work with. Happy to review a second pass :) |
Some standardization edits, given diff writers between docs.
Primary updates:
Eth2Genesis
or the spec name eth2.0-specs, ofc also left as is)Misc.: