Added tree hashing algorithm #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2018
djrtwo
reviewed
Nov 10, 2018
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Nov 12, 2018
mkalinin
reviewed
Nov 12, 2018
|
It would be nice to have an example of |
@mkalinin you can find this here: https://github.com/ethereum/beacon_chain/blob/vitalik_hash_ssz/hash_ssz.py I imagine @djrtwo will copy the code or something like it into the python impl once this gets finalized/approved. |
arnetheduck
reviewed
Nov 14, 2018
specs/simple-serialize.md
Outdated
| chunkz.append(b'\x00' * CHUNKSIZE) | ||
| chunkz = [hash(chunkz[i] + chunkz[i+1]) for i in range(0, len(chunkz), 2)] | ||
| # Return hash of root and length data | ||
| return hash(chunkz[0] + datalen) |
There was a problem hiding this comment.
nitpick: lst / chunkz can be empty in the general case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to the SSZ spec an algorithm for tree-hashing SSZ objects.
Experiments suggest that the hashing time required is increased by a factor of ~4-6, partly because Merkle hashing inherently raises the amount of data hashes due to multiple layers of hashing and partially because hash functions have a fixed computation cost in addition to the per-byte cost.