Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sanity dir to under phase_0 #1769

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Move sanity dir to under phase_0 #1769

merged 1 commit into from
Apr 28, 2020

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Apr 28, 2020

Rationale

  1. Define that the tests under phase_x are "the tests new to phase x".
  2. By (1), the sanity tests should just be moved to under phase_0.

No substantive change here, the test vectors should be the same.

protolambda
protolambda approved these changes Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djrtwo
Copy link
Contributor

djrtwo commented Apr 28, 2020

I'm checking that sanity generators work locally before merge

@djrtwo
Copy link
Contributor

djrtwo commented Apr 28, 2020

yup! all good

@djrtwo djrtwo merged commit b5ecc88 into dev Apr 28, 2020
@djrtwo djrtwo deleted the hwwhww/move_sanity branch April 28, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

@djrtwo djrtwo Awaiting requested review from djrtwo

Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwwhww @djrtwo @protolambda