Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test double proposer slashings and exits #1781

Merged
merged 4 commits into from
May 7, 2020
Merged

test double proposer slashings and exits #1781

merged 4 commits into from
May 7, 2020

Conversation

protolambda
Copy link
Collaborator

See #1760

I looked into AttesterSlashing tests, but the current mainnet config does not permit double events within a block, and if it were, it would still be a valid case, so clients are more likely to recover.

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! a couple of minor suggestions

tests/core/pyspec/eth2spec/test/sanity/test_blocks.py Outdated Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/sanity/test_blocks.py Outdated Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/sanity/test_blocks.py Outdated Show resolved Hide resolved
@djrtwo djrtwo added this to the v0.12.0 milestone May 7, 2020
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few tests and handled a couple of PR feedback items

@djrtwo djrtwo merged commit 197f1f5 into dev May 7, 2020
@djrtwo djrtwo deleted the double-operations branch May 7, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants