Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shard field to ShardBlock #1853

Merged
merged 1 commit into from
May 28, 2020
Merged

Add shard field to ShardBlock #1853

merged 1 commit into from
May 28, 2020

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented May 28, 2020

Issue

Per #1850 point 2, add shard to ShardBlock.

How did I solve it

  1. Add add shard to ShardBlock and ShardBlockHeader.
  2. Add verification in verify_shard_block_message.

/cc @terencechain

@hwwhww hwwhww added the phase1 label May 28, 2020
@terencechain
Copy link
Contributor

Looks good to me!

@djrtwo djrtwo merged commit 4cbe51b into dev May 28, 2020
@djrtwo djrtwo deleted the hwwhww/shard_block branch May 28, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
phase1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwwhww @terencechain @djrtwo