Tidying up shard_state_transition
#1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
reviewed
Jun 2, 2020
Comment on lines
80
to
85
| shard_state.transition_digest = compute_shard_transition_digest( | ||
| beacon_state, | ||
| shard_state, | ||
| block.beacon_parent_root, | ||
| hash_tree_root(block.body), | ||
| ) |
There was a problem hiding this comment.
What do you think about moving transition_digest changes to the last? So that transition_digest would serve more like the state_root in the beacon chain.
There was a problem hiding this comment.
Sounds good to me. Thanks for looking!
djrtwo
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list:
#Update shard statewith triple quotes comment