Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify what 'state' is for block proposals in validator guide #2022

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Aug 19, 2020

Clarify state for block proposals in validator guide to resolve #2012

Note! The addition of these two lines are the only change:

*Note*: In this section, `state` is the state of the slot for the block proposal _without_ the block yet applied.
That is, `state` is the `previous_state` processed through any empty slots up to the assigned slot using `process_slots(previous_state, slot)`.

I started breaking up long lines in the validator guide (like the p2p spec). Will help with diffs in the future but some pain right now

@djrtwo djrtwo requested a review from hwwhww August 19, 2020 15:58
There is one proposer per slot, so if there are N active validators any individual validator
will on average be assigned to propose once per N slots (e.g. at 312,500 validators = 10 million ETH, that's once per ~6 weeks).

*Note*: In this sectio, `state` is the state of the slot for the block proposal _without_ the block yet applied.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note! These two lines are the only change.

I started breaking up long lines in the validator guide (like the p2p spec). Will help with diffs in the future but some pain right now

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, otherwise looks good to me

specs/phase0/validator.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just one unrelated nitpicking.

specs/phase0/validator.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Won't honest validators update ETH1 data every two voting periods?
3 participants