Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use raw SHA256 as message-id and reduce size to 8 bytes #2044

Merged
merged 5 commits into from
Sep 14, 2020
Merged

use raw SHA256 as message-id and reduce size to 8 bytes #2044

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9cbc7c3
use raw SHA256 as message-id
blacktemplar Sep 9, 2020
8f0b15f
remove dot
blacktemplar Sep 11, 2020
deb58fd
only use first 8 bytes of hash as message id
blacktemplar Sep 14, 2020
89be1f5
favor pythonic notation for array slices
djrtwo Sep 14, 2020
5a9fe89
remove extraneous parens
djrtwo Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions specs/phase0/p2p-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,11 @@ Each gossipsub [message](https://github.com/libp2p/go-libp2p-pubsub/blob/master/
Clients MUST reject (fail validation) messages that are over this size limit.
Likewise, clients MUST NOT emit or propagate messages larger than this limit.

The `message-id` of a gossipsub message MUST be:
The `message-id` of a gossipsub message MUST be the first 8 bytes of the SHA-256 hash of the message data, i.e.:

```python
message-id: base64(SHA256(message.data))
message-id: SHA256(message.data)[0:8]
```
where `base64` is the [URL-safe base64 alphabet](https://tools.ietf.org/html/rfc4648#section-3.2) with padding characters omitted.

The payload is carried in the `data` field of a gossipsub message, and varies depending on the topic:

Expand Down