remove prepare_payload #2683
Merged
remove prepare_payload #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
force-pushed
the
remove-prepare-payload
branch
from
f17619e
to
d5be6b5
Compare
djrtwo
commented
Oct 19, 2021
|
|
||
| ### `ExecutionEngine` | ||
| ### `get_pow_block_at_terminal_total_difficulty` |
There was a problem hiding this comment.
Moved get_pow_block_at_terminal_total_difficulty and get_terminal_pow_block up to helpers section.
No changes made to contents of the functions.
djrtwo
commented
Oct 19, 2021
mkalinin
approved these changes
Oct 19, 2021
23 tasks
24 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
prepare_payloadin favor of a unification withnotifiy_forkchoice_updatedto map the methods as they are in the engine API.See here -- ethereum/execution-apis#83 -- for associated removal in the engine API.