Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove difficulty from PowBlock #2720

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Remove difficulty from PowBlock #2720

merged 2 commits into from
Nov 18, 2021

Conversation

paulhauner
Copy link
Contributor

The difficulty field is unused in the specification and appears to be always set to 0 in fork choice tests.

mkalinin
mkalinin approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be a leftover from the times when the TTD was computed during the fork on the beacon chain. We may remove it now 👍

@hwwhww
Copy link
Contributor

hwwhww commented Nov 16, 2021

Nice. I'll go fix the CI.

@hwwhww hwwhww self-assigned this Nov 16, 2021
@hwwhww hwwhww removed their assignment Nov 16, 2021
@dapplion dapplion mentioned this pull request Nov 18, 2021
Closed
24 tasks
@djrtwo djrtwo merged commit dc14b79 into ethereum:dev Nov 18, 2021
@hwwhww hwwhww added the Bellatrix CL+EL Merge label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

@mkalinin mkalinin mkalinin approved these changes

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
Bellatrix CL+EL Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulhauner @hwwhww @djrtwo @mkalinin