Remove justified block from optimistic candidate conditions #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Apr 28, 2022
|
Same with prysm |
djrtwo
approved these changes
Apr 29, 2022
18 tasks
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Aug 17, 2022
## Issue Addressed Implements spec change ethereum/consensus-specs#2881 ## Proposed Changes Remove the justified block check from `is_optimistic_candidate_block`.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Implements spec change ethereum/consensus-specs#2881 ## Proposed Changes Remove the justified block check from `is_optimistic_candidate_block`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the spec by removing "The justified checkpoint has execution enabled" condition from optimistic candidate evaluation.
Removal of this conditions implies a tiny change in client behaviour. Before the change, justification of a merge block immediately allowed to safely import blocks from any other chains. After the change, it becomes allowed only when
SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLYruns out. This negligible change doesn't affect security of merge transition process.cc @paulhauner @ajsutton @potuz