Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty blobs and commitments #3093

Merged
merged 16 commits into from
Nov 23, 2022
Merged

Allow empty blobs and commitments #3093

merged 16 commits into from
Nov 23, 2022

Commits on Nov 11, 2022

  1. allow empty blobs: 

    - Put the code related to computing challenges in another method

- remove panic on poly_lincomb() when `polys` is empty
    @kevaundray
    kevaundray committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    4a4be2e View commit details
    Browse the repository at this point in the history

  2. use correct variable names

    @kevaundray
    kevaundray committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    88dfcc4 View commit details
    Browse the repository at this point in the history

  3. asn review

    @kevaundray
    kevaundray committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    a6f3a79 View commit details
    Browse the repository at this point in the history

  4. add test for zero blobs

    @kevaundray
    kevaundray committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    c786708 View commit details
    Browse the repository at this point in the history

  5. Fix linter errors

    @asn-d6
    asn-d6 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    3327c0b View commit details
    Browse the repository at this point in the history

  6. Add defensive assert to make sure that input length is consistent

    @asn-d6
    asn-d6 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    b7515f7 View commit details
    Browse the repository at this point in the history

  7. dankrad review

    @kevaundray
    kevaundray committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    4703471 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. use challenge index to generate linear combination challenges and eva… 

    …luation challenge
    @kevaundray
    kevaundray committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    d4c6a69 View commit details
    Browse the repository at this point in the history

  2. use an integer and convert challenge_index to bytes

    @kevaundray
    kevaundray committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    73adfa5 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Satisfy linter

    @asn-d6
    asn-d6 committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    d0489bc View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Add defensive assert in poly_lincomb() and some comments

    @asn-d6
    asn-d6 committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7a41107 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into kw/allow-empty-blobs

    @kevaundray
    kevaundray authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    b9b7fd3 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Update specs/eip4844/polynomial-commitments.md 

    Co-authored-by: dankrad <[email protected]>
    @kevaundray @dankrad
    kevaundray and dankrad authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    80dd7be View commit details
    Browse the repository at this point in the history

  2. cleanup comments and extra return

    @kevaundray
    kevaundray committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    946fd5f View commit details
    Browse the repository at this point in the history

  3. Do bytes conversion of challenge_index on a separate line for readabi… 

    …lity
    @kevaundray
    kevaundray committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    7ea0f9c View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Move entire FS logic into compute_challenges()

    @asn-d6
    asn-d6 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    eacf448 View commit details
    Browse the repository at this point in the history