Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP4844: Update MAX_BLOBS_PER_BLOCK to 4 #3145

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

terencechain
Copy link
Contributor

Update MAX_BLOBS_PER_BLOCK to 4 to align with the EIP

Currently, the TARGET_DATA_GAS_PER_BLOCK and MAX_DATA_GAS_PER_BLOCK have chosen to target two blobs (0.25 MB) and a maximum of four blobs (0.5 MB) per block

@hwwhww
Copy link
Contributor

hwwhww commented Dec 1, 2022

Hi @terencechain, I fixed the tests accordingly.

I suppose it is not part of the EIP-4844 devnet-3? Since we are planning to cut another Capella spec release next week, I labeled this as DO-NOT-MERGE for now.

@hwwhww hwwhww added the Deneb was called: eip-4844 label Dec 1, 2022
@terencechain
Copy link
Contributor Author

I suppose it is not part of the EIP-4844 devnet-3? Since we are planning to cut another Capella spec release next week, I labeled this as DO-NOT-MERGE for now.

I doubt it will be devnet-3, but I think we can clarify this during the implementer's call

@dapplion
Copy link
Collaborator

dapplion commented Dec 5, 2022

.oO

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on 4844 call -- let's merge. EL is targeting master on the EIP so we should make sure the constants are coherent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deneb was called: eip-4844
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants