EIP4844: Enable withdrawal #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
approved these changes
Dec 30, 2022
|
I'm cool leaving this as a placeholder but there is quite a bit of testing code to re-enable before this gets merged. And for the record, I too would like to get this back into it's final form as soon as is feasible |
This was referenced Jan 3, 2023
|
I can update the test suite quickly. Just please ensure it is what EIP-4844 interop wants and when. :) |
hwwhww
force-pushed
the
4844-enable-withdrawal
branch
from
8d48b0f
to
da79f3f
Compare
hwwhww
force-pushed
the
4844-enable-withdrawal
branch
from
da79f3f
to
dba75ee
Compare
|
Update: per the EIP-4844 call decision (ethereum/pm#701), let's aim to include it in the next release! I pushed commits to update the tests. Now running the testgen. I will review it again tomorrow. |
10 tasks
hwwhww
approved these changes
Jan 4, 2023
|
Thanks so much @hwwhww ! |
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given EIP4844 is decoupled from Shanghai and targeted for Cancun, and with the withdrawal spec almost finalized, it'd make sense to enable withdrawal for the subsequent 4844 devnets. This is more realistic to what the final product would look like, and it's cleaner for the client implementations, the less "custom" code, the better.
No rush to merge this. I think we can target this for devnet4.