Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for vanity art #3320

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Conversation

etan-status
Copy link
Contributor

Update specifications to match client implementation behaviour regarding optional vanity art being displayed when certain conditions are met.

Update specifications to match client implementation behaviour regarding
optional vanity art being displayed when certain conditions are met.
@ppopth
Copy link
Member

ppopth commented Apr 25, 2023

Why should we have all the clients follow this art spec?

This seems to me that it's an implementation thing rather than a spec thing. The protocol will work fine if not all the clients follow the art spec.

Even though it's marked as optional, it's still a sign that we convince all the clients to follow the spec if we put it in the spec.

@ppopth
Copy link
Member

ppopth commented Apr 25, 2023

This seems related to #2875

@etan-status etan-status marked this pull request as draft October 9, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants