Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify/fix things in blob requests #3540

Merged
merged 1 commit into from
Nov 2, 2023
Merged

clarify/fix things in blob requests #3540

merged 1 commit into from
Nov 2, 2023

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Nov 2, 2023

  • Remove the (now incorrect) note about the blob signature
  • add that a client SHOULD check the inclusion proof when doing consistency/validation checks

I'm not sure we should put much more on validations here. Looking at the beaconblock sync methods (byRoot and byRange), we are very minimal on what conditions to perform and where (other than the actual block verificaitons which happen downstream in whatever pipeline the client chooses)

Open to feedback

hwwhww
hwwhww approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@djrtwo djrtwo mentioned this pull request Nov 2, 2023
Merged
5 tasks
@djrtwo djrtwo merged commit 09c14f0 into dev Nov 2, 2023
26 checks passed
@djrtwo djrtwo deleted the blob-by branch November 2, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @hwwhww