-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v1.5.0-alpha.3 #3786
Merged
release v1.5.0-alpha.3 #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Dankrad Feist <[email protected]>
Co-authored-by: terencechain <[email protected]>
Co-authored-by: Mikhail Kalinin <[email protected]>
Co-authored-by: Mikhail Kalinin <[email protected]>
Co-Authored-By: dapplion <[email protected]>
I'll do this in a separate PR.
Add electra version of AggregateAndProof
Provide Max Size For Columns By Range Request
Change duplicate cell id test to use 65 cell ids
* EIP-7594: add custody settings config * Add `TARGET_NUMBER_OF_PEERS` to config * add TARGET_NUMBER_OF_PEERS Co-authored-by: Hsiao-Wei Wang <[email protected]> * fix double TARGET_NUMBER_OF_PEERS * fix tests --------- Co-authored-by: Hsiao-Wei Wang <[email protected]>
Introducing new fields in the middle of an existing `Container` pointlessly breaks merkleization of all subsequent fields. In the case of `committee_bits`, it is also misleading, as `signature` only covers `data` inside `Attestation`.
Proposal for #3744
Remove `compute_cells` method
* multi: - Remove shift_polynomial_coeff - Remove recover_shifted_data - Remove recover_original_data - Move `zero_poly_eval_brp ` under sanity check comment as its only used for sanity checking * chore: remove sanity check -- this was doing a wasteful `compute_root_of_unity` operation * chore: add previous sanity check as a unit test * chore: copy values python was taking a reference, so it passes in our regular codepaths but not in isolated test * chore: add coset_fft test * Update specs/_features/eip7594/polynomial-commitments-sampling.md Co-authored-by: Justin Traglia <[email protected]> * Update specs/_features/eip7594/polynomial-commitments-sampling.md Co-authored-by: Justin Traglia <[email protected]> * chore: linter * chore: asn (switch to bls_modular_inverse) * chore: (ben) rename func to test_construct_vanishing_polynomial * chore: (ben) rename `extended_evaluations_coeffs` to `extended_evaluation_times_zero_coeffs` * chore: compute `roots_of_unity_extended` in recover_data method * chore: add more comments explaining whats happening in recover_data * chore: compute_zero_poly_coeff in recover_data * chore: make lint * chore: add doc comment to coset_fft_field * chore: (ben) add code to generate the vanishing polynomial when all cells are missing * chore: remove handling of edge case when constructing a vanishing polynomial * chore: rename H(x) to Q_3(x) * chore: remove trailing whitespace * chore: add whitespace between comments * chore: (asn) add assert that num missing cells is not 0 * chore: (justin) address comments * chore: merge resolution * chore: fixup remaining IDs -> indices * chore: use indice nomenclature in tests --------- Co-authored-by: Justin Traglia <[email protected]>
* Add support for the CI to generate the test vectors
Update compute_el_header_block_hash for EIP-7685
EIP-7594 - Update ENR record
EIP-7549: Append new `committee_bits` field to end of `Attestation`
2 tasks
Co-authored-by: Hsiao-Wei Wang <[email protected]>
EIP-7594: Fix Dead Link
bump version to `1.5.0-alpha.3`
Co-authored-by: Hsiao-Wei Wang <[email protected]>
Switch the rest of the spec to MAX_EFFECTIVE_BALANCE_ELECTRA
EIP7594-Polynomial-Commitments-Tests: Extend Tests for FFT and Coset FFT.
…-hotfix Remove `assert len(missing_cell_indices) != 0` check
Nichebiche
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge to main branch
Thompson1985
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking if we can cut a new Electra alpha release later this week. As potential devnet-1 target.
Ready to merge:
Checking status
committee_bits
field to end ofAttestation
#3768 ?EIP-7251: Stricter bound for consolidation queue #3661 ?TODOs